[jira] [Commented] (RANGER-1991) Fix problems detected by static code analysis

["Zsombor Gegesy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RANGER-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383681#comment-16383681 ] 

Zsombor Gegesy commented on RANGER-1991:
----------------------------------------

Commited to 1.0 branch: https://github.com/apache/ranger/commit/fdce224fa1aa63eba2fec2dce52f3d5ac3532df6

> Fix problems detected by static code analysis
> ---------------------------------------------
>
>                 Key: RANGER-1991
>                 URL: https://issues.apache.org/jira/browse/RANGER-1991
>             Project: Ranger
>          Issue Type: Bug
>          Components: admin
>    Affects Versions: 0.7.1
>            Reporter: Zsombor Gegesy
>            Assignee: Zsombor Gegesy
>            Priority: Minor
>              Labels: code-cleanup, findbugs
>             Fix For: 1.0.0
>
>         Attachments: RANGER-1991.patch
>
>
> FindBugs/SpotBug detects a couple of problems with the code base:
>  * Incorrect class casting - in XXServiceDef.equals
>  * Unnecessary NPE checks - for variables which is known to be non-null (for example, because in other places a method is called on that object). In ServiceREST.java PublicAPIs.java, ServiceUtil.java and independently in XUserMgr.java
>  * Collection.contains method call which is never true - in ServiceDBStore.validatePolicyItems for policyItem.getAccesses().contains("") - because getAccesses doesn't store String objects
>  * Making public partially initialized objects in HadoopConfigHolder.initResourceMap()
>  * Calling toString on array, which is not too readable
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)