You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/18 01:07:09 UTC
[GitHub] [arrow] kou opened a new pull request #10738: ARROW-13219: [C++][GLib] Demote/deprecate CompareOptions
kou opened a new pull request #10738:
URL: https://github.com/apache/arrow/pull/10738
CompareOptions is not properly a FunctionOptions but it has bindings
in GLib that expect it to be a FunctionOptions. After
https://issues.apache.org/jira/browse/ARROW-13025, we should make
CompareOptions a bare struct (instead of a FunctionOptions subclass)
and deprecate it in favor of just specifying the comparison operator
directly.
In C++, CompareOptions exists and is deprecated.
In GLib, GArrowCompareOptions and related APIs are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10738: ARROW-13219: [C++][GLib] Demote/deprecate CompareOptions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10738:
URL: https://github.com/apache/arrow/pull/10738#issuecomment-881981187
https://issues.apache.org/jira/browse/ARROW-13219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #10738: ARROW-13219: [C++][GLib] Demote/deprecate CompareOptions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #10738:
URL: https://github.com/apache/arrow/pull/10738#discussion_r671933809
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -218,11 +218,9 @@ enum CompareOperator : int8_t {
LESS_EQUAL,
};
-class ARROW_EXPORT CompareOptions : public FunctionOptions {
Review comment:
Thank you! I filed ARROW-13378.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #10738: ARROW-13219: [C++][GLib] Demote/deprecate CompareOptions
Posted by GitBox <gi...@apache.org>.
kou closed pull request #10738:
URL: https://github.com/apache/arrow/pull/10738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #10738: ARROW-13219: [C++][GLib] Demote/deprecate CompareOptions
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10738:
URL: https://github.com/apache/arrow/pull/10738#discussion_r671919282
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -218,11 +218,9 @@ enum CompareOperator : int8_t {
LESS_EQUAL,
};
-class ARROW_EXPORT CompareOptions : public FunctionOptions {
Review comment:
OK. I'll merge this as-is.
Let's do extra work as a follow-up task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #10738: ARROW-13219: [C++][GLib] Demote/deprecate CompareOptions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #10738:
URL: https://github.com/apache/arrow/pull/10738#discussion_r671764971
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -218,11 +218,9 @@ enum CompareOperator : int8_t {
LESS_EQUAL,
};
-class ARROW_EXPORT CompareOptions : public FunctionOptions {
Review comment:
On second thought, deprecating the enum would make some of the tests/benchmarks below annoying to write and it would be a tedious refactor. So let's not do that here - since this is about GLib - once this removes the GLib dependency we can go in and fully clean up CompareOptions.
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -218,11 +218,9 @@ enum CompareOperator : int8_t {
LESS_EQUAL,
};
-class ARROW_EXPORT CompareOptions : public FunctionOptions {
Review comment:
Perhaps we should deprecate the struct and CompareOperator enum as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org