You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/03 09:11:57 UTC

[GitHub] [orc] pgaref opened a new pull request #599: ORC-708: Use maven command directly

pgaref opened a new pull request #599:
URL: https://github.com/apache/orc/pull/599


   ### What changes were proposed in this pull request?
   
   This PR aims to use `maven deploy` directly.
   
   ### Why are the changes needed?
   
   Apache repository doesn't allow 3rd party GitHub Action script.
   
   ### How was this patch tested?
   
   Tested locally.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #599: ORC-708: Use maven command directly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #599:
URL: https://github.com/apache/orc/pull/599#issuecomment-753600380


   Please note that `force-push` breaks the downstream repositories and enforces the downstream also need to do force-push accordingly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #599: ORC-708: Use maven command directly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #599:
URL: https://github.com/apache/orc/pull/599#issuecomment-753600202


   @pgaref . It's recoverable, but here are some tips for you.
   1. First of all, when you make a PR branch, please make a branch from Apache branch, not from outdated your local branch to avoid this kind of issue from the beginning.
   2. Second, please don't merge your PR by yourself. Usually, +1 from other committer is the requirement although you can still merge it and get approval after merging.
   3. Third, please stop do `force-pushing` at any reason. That should be the last resort.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] pgaref commented on pull request #599: ORC-708: Use maven command directly

Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #599:
URL: https://github.com/apache/orc/pull/599#issuecomment-753599534


   Hey @dongjoon-hyun  -- while merging #599 an extra dummy commit was created in the branch.
   I did try to clean this up by force pushing and created a mess as I had two more branches locally tracking apache/orc.
   
   I did manage to recover everything but caused all this mess. So sorry about this.
   At this point, I am even thinking that force pushing should be even disabled at repo level to avoid this


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] pgaref merged pull request #599: ORC-708: Use maven command directly

Posted by GitBox <gi...@apache.org>.
pgaref merged pull request #599:
URL: https://github.com/apache/orc/pull/599


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #599: ORC-708: Use maven command directly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #599:
URL: https://github.com/apache/orc/pull/599#issuecomment-753599098


   Ditto. Any explanation about this, @pgaref ?
   Why do you reset the branch and handle like this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] pgaref edited a comment on pull request #599: ORC-708: Use maven command directly

Posted by GitBox <gi...@apache.org>.
pgaref edited a comment on pull request #599:
URL: https://github.com/apache/orc/pull/599#issuecomment-753599534


   Hey @dongjoon-hyun  -- while merging #599 an extra dummy commit was created in the branch.
   I did try to clean this up by force pushing and created a mess as I had two more branches locally tracking apache/orc (master and 1.5).
   
   I did manage to recover everything but caused all this mess. So sorry about this.
   At this point, I am even thinking that force pushing should be even disabled at repo level to avoid this


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org