[GitHub] [arrow] maartenbreddels commented on pull request #7656: ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

[GitBox <gi...@apache.org>]

maartenbreddels commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-654991684


   I wanted to focus on the other issues first, but I propose a change in naming by this:
    `<arrow type>_<func>_<variant>`, since all you care about is that it's a function that operates on a string and all the ascii variants with with all utf8 strings. Also, I don't know if in the future there will be utf16/utf32 support, in that case, this naming scheme makes more sense. I'm ok changing it back or open a PR to make this consistent (`string_lower_ascii`, `string_lower_uncode`, ... etc).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org