You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by sa...@locus.apache.org on 2000/06/12 19:24:10 UTC

cvs commit: apache-2.0/src Makefile.in

sascha      00/06/12 10:24:10

  Modified:    src      Makefile.in
  Log:
  Finish the switch to light-wheight pcre.
  
  Revision  Changes    Path
  1.22      +1 -2      apache-2.0/src/Makefile.in
  
  Index: Makefile.in
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/Makefile.in,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -u -r1.21 -r1.22
  --- Makefile.in	2000/05/16 10:57:27	1.21
  +++ Makefile.in	2000/06/12 17:24:09	1.22
  @@ -11,8 +11,7 @@
     os/$(OS_DIR)/libos.la \
     ap/libap.la \
     lib/apr/$(LIBPRE)apr.a \
  -  lib/pcre/libpcreposix.a \
  -  lib/pcre/libpcre.a
  +  lib/pcre/libpcre.la
   
   PROGRAMS        = $(PROGRAM_NAME)
   targets         = $(PROGRAMS)
  
  
  

Re: cvs commit: apache-2.0/src Makefile.in

Posted by Sascha Schumann <sa...@schumann.cx>.
On Mon, 12 Jun 2000 rbb@covalent.net wrote:

> 
> >      os/$(OS_DIR)/libos.la \
> >      ap/libap.la \
> >      lib/apr/$(LIBPRE)apr.a \
> >   -  lib/pcre/libpcreposix.a \
> >   -  lib/pcre/libpcre.a
> >   +  lib/pcre/libpcre.la
> 
> Don't we want to be using the posix part of PCRE?  This means we aren't
> using the POSIX calls that PCRE provides.  IMHO, this is a bad idea.

    pcreposix.c is compiled into libpcre.la.

    Btw, the build is still broken:

    /home/sas/src/apache-2.0/src/modules/mpm/mpmt_pthread/mpmt_pthread.c:
    In function `set_coredumpdir':
    /home/sas/src/apache-2.0/src/modules/mpm/mpmt_pthread/mpmt_pthread.c:1434:
    storage size of `finfo' isn't known
    /home/sas/src/apache-2.0/src/modules/mpm/mpmt_pthread/mpmt_pthread.c:1442:
    `finfofname' undeclared (first use in this function)
    /home/sas/src/apache-2.0/src/modules/mpm/mpmt_pthread/mpmt_pthread.c:1442:
    (Each undeclared identifier is reported only once
    /home/sas/src/apache-2.0/src/modules/mpm/mpmt_pthread/mpmt_pthread.c:1442:
    for each function it appears in.)
    /home/sas/src/apache-2.0/src/modules/mpm/mpmt_pthread/mpmt_pthread.c:1442:
    warning: passing arg 2 of `ap_stat' from incompatible pointer
    type
    /home/sas/src/apache-2.0/src/modules/mpm/mpmt_pthread/mpmt_pthread.c:1442:
    too few arguments to function `ap_stat'
    
    - Sascha


Re: cvs commit: apache-2.0/src Makefile.in

Posted by rb...@covalent.net.
>      os/$(OS_DIR)/libos.la \
>      ap/libap.la \
>      lib/apr/$(LIBPRE)apr.a \
>   -  lib/pcre/libpcreposix.a \
>   -  lib/pcre/libpcre.a
>   +  lib/pcre/libpcre.la

Don't we want to be using the posix part of PCRE?  This means we aren't
using the POSIX calls that PCRE provides.  IMHO, this is a bad idea.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Re: cvs commit: apache-2.0/src Makefile.in

Posted by rb...@covalent.net.
>      os/$(OS_DIR)/libos.la \
>      ap/libap.la \
>      lib/apr/$(LIBPRE)apr.a \
>   -  lib/pcre/libpcreposix.a \
>   -  lib/pcre/libpcre.a
>   +  lib/pcre/libpcre.la

Don't we want to be using the posix part of PCRE?  This means we aren't
using the POSIX calls that PCRE provides.  IMHO, this is a bad idea.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------