You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/05/21 22:54:15 UTC
Review Request 67239: ATLAS-2710: basic-search doesn't return deleted
entities though excludeDeletedEntities is False
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67239/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2710
https://issues.apache.org/jira/browse/ATLAS-2710
Repository: atlas
Description
-------
This is caused by entity-delete removing vertex property that stores associated classification names. This property is used by basic-search to look for entities, hence the deleted entity was not returned.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f417b4e95
Diff: https://reviews.apache.org/r/67239/diff/1/
Testing
-------
Verified that basic-search returns deleted entities as well when excludeDeletedEntities is False.
Thanks,
Madhan Neethiraj
Re: Review Request 67239: ATLAS-2710: basic-search doesn't return
deleted entities though excludeDeletedEntities is False
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67239/#review203543
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On May 21, 2018, 10:54 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67239/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 10:54 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2710
> https://issues.apache.org/jira/browse/ATLAS-2710
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is caused by entity-delete removing vertex property that stores associated classification names. This property is used by basic-search to look for entities, hence the deleted entity was not returned.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f417b4e95
>
>
> Diff: https://reviews.apache.org/r/67239/diff/1/
>
>
> Testing
> -------
>
> Verified that basic-search returns deleted entities as well when excludeDeletedEntities is False.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 67239: ATLAS-2710: basic-search doesn't return
deleted entities though excludeDeletedEntities is False
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67239/
-----------------------------------------------------------
(Updated May 22, 2018, 12:12 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2710
https://issues.apache.org/jira/browse/ATLAS-2710
Repository: atlas
Description
-------
This is caused by entity-delete removing vertex property that stores associated classification names. This property is used by basic-search to look for entities, hence the deleted entity was not returned.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java f417b4e95
Diff: https://reviews.apache.org/r/67239/diff/1/
Testing (updated)
-------
Verified that basic-search returns deleted entities as well when excludeDeletedEntities is False.
Pre-commit test: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/425/
Thanks,
Madhan Neethiraj