[GitHub] [superset] dpgaspar commented on pull request #21515: feat: new config to filter specific users from dropdown lists

[GitBox <gi...@apache.org>]

dpgaspar commented on PR #21515:
URL: https://github.com/apache/superset/pull/21515#issuecomment-1254924420

   > Should this be an attribute for the `User` model instead, or potentially a config/method in SecurityManager (which users can already override)? We should really try our best to reduce the number of config keys added plus setting this in config would also mean new service accounts cannot be added without a new deployment of Superset.
   
   Very good point, an extra attribute for the `User` model could be tricky. I've chose to do both, config key and a security manager method to override. Config key if not `None` will take precedence.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org