You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/08 23:59:13 UTC

[GitHub] [airflow] jhtimmins opened a new pull request #8794: Use fork when test relies on mock.patch in parent process.

jhtimmins opened a new pull request #8794:
URL: https://github.com/apache/airflow/pull/8794


   The `test_scheduler_reschedule` method fails when creating processes in `spawn` mode, which is the default mode for Python 3.8 on MacOS. 
   
   `test_scheduler_reschedule` depends on `mock.patch()` decorators around the `.do_schedule()` method in the parent process to mock `DagBag` objects in the child process. Since spawn mode limits the amount of parent state accessible within the child process, `DagBag` is not properly mocked in the new process, causing the test to fail.
   
   This PR forces the test to use `fork` instead of `spawn` when creating a child process, allowing the mocks to work as intended.
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org