You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/13 09:10:21 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #20144: Revise ImporterCreator and ImporterCreatorFactoryTest
sandynz opened a new pull request, #20144:
URL: https://github.com/apache/shardingsphere/pull/20144
Related to #19938.
Changes proposed in this pull request:
- Improve code style of ImporterCreator and related code
- Remove unnecessary ImporterCreator SPI registration
- Improve ImporterCreatorFactoryTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20144: Revise ImporterCreator and ImporterCreatorFactoryTest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20144:
URL: https://github.com/apache/shardingsphere/pull/20144#issuecomment-1214132049
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20144?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20144](https://codecov.io/gh/apache/shardingsphere/pull/20144?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (306c3ec) into [master](https://codecov.io/gh/apache/shardingsphere/commit/201b83c356fe9ee4d588de7535ea59ab3bfd61dd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (201b83c) will **decrease** coverage by `0.00%`.
> The diff coverage is `51.85%`.
> :exclamation: Current head 306c3ec differs from pull request most recent head 99ca6c0. Consider uploading reports for the commit 99ca6c0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #20144 +/- ##
============================================
- Coverage 60.52% 60.51% -0.01%
+ Complexity 2420 2419 -1
============================================
Files 3860 3869 +9
Lines 54761 54811 +50
Branches 7679 7682 +3
============================================
+ Hits 33142 33170 +28
- Misses 18767 18787 +20
- Partials 2852 2854 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvY29yZS9rZXJuZWwvS2VybmVsRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ache/shardingsphere/error/SQLExceptionHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZXJyb3Ivc2hhcmRpbmdzcGhlcmUtY29tbW9uLWVycm9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lcnJvci9TUUxFeGNlcHRpb25IYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...phere/error/mysql/mapper/MySQLExceptionMapper.java](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZXJyb3Ivc2hhcmRpbmdzcGhlcmUtbXlzcWwtZXJyb3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Vycm9yL215c3FsL21hcHBlci9NeVNRTEV4Y2VwdGlvbk1hcHBlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ere/error/postgresql/code/PostgreSQLErrorCode.java](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZXJyb3Ivc2hhcmRpbmdzcGhlcmUtcG9zdGdyZXNxbC1lcnJvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZXJyb3IvcG9zdGdyZXNxbC9jb2RlL1Bvc3RncmVTUUxFcnJvckNvZGUuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ere/error/postgresql/sqlstate/PostgreSQLState.java](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZXJyb3Ivc2hhcmRpbmdzcGhlcmUtcG9zdGdyZXNxbC1lcnJvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZXJyb3IvcG9zdGdyZXNxbC9zcWxzdGF0ZS9Qb3N0Z3JlU1FMU3RhdGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ty/distsql/parser/core/AuthorityDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWF1dGhvcml0eS9zaGFyZGluZ3NwaGVyZS1hdXRob3JpdHktZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1hdXRob3JpdHktZGlzdHNxbC1wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2F1dGhvcml0eS9kaXN0c3FsL3BhcnNlci9jb3JlL0F1dGhvcml0eURpc3RTUUxQYXJzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../parser/core/AuthorityDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWF1dGhvcml0eS9zaGFyZGluZ3NwaGVyZS1hdXRob3JpdHktZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1hdXRob3JpdHktZGlzdHNxbC1wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2F1dGhvcml0eS9kaXN0c3FsL3BhcnNlci9jb3JlL0F1dGhvcml0eURpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../facade/AuthorityDistSQLStatementParserFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWF1dGhvcml0eS9zaGFyZGluZ3NwaGVyZS1hdXRob3JpdHktZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1hdXRob3JpdHktZGlzdHNxbC1wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2F1dGhvcml0eS9kaXN0c3FsL3BhcnNlci9mYWNhZGUvQXV0aG9yaXR5RGlzdFNRTFN0YXRlbWVudFBhcnNlckZhY2FkZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...pipeline/core/importer/DefaultImporterCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW1wb3J0ZXIvRGVmYXVsdEltcG9ydGVyQ3JlYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...pipeline/core/importer/ImporterCreatorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvaW1wb3J0ZXIvSW1wb3J0ZXJDcmVhdG9yRmFjdG9yeS5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/shardingsphere/pull/20144/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb merged pull request #20144: Revise ImporterCreator and ImporterCreatorFactoryTest
Posted by GitBox <gi...@apache.org>.
zjcnb merged PR #20144:
URL: https://github.com/apache/shardingsphere/pull/20144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org