You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rok (via GitHub)" <gi...@apache.org> on 2025/07/31 14:25:47 UTC
[PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
rok opened a new pull request, #47249:
URL: https://github.com/apache/arrow/pull/47249
### Rationale for this change
This PR is mostly for executing reproduction on windows CI machines.
### What changes are included in this PR?
### Are these changes tested?
### Are there any user-facing changes?
**This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
**This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3144015718
Revision: 2a5b093fe13beebfe5f690ba9221a4333e22b00d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6614a425dd](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6614a425dd)
|Task|Status|
|----|------|
|wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16672355348/job/47191313875)|
|wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16672355297/job/47191313898)|
|wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16672355305/job/47191313858)|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16672355312/job/47191313884)|
|wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16672355388/job/47191313973)|
|wheel-windows-cp39-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/16672355416/job/47191314043)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292156950
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] Add test for fill_null regression on Windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #47249:
URL: https://github.com/apache/arrow/pull/47249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3196711820
Revision: ca3a37bf7bb1d0d2383eb644b69ab1c5d08b67c4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-044cc0b452](https://github.com/ursacomputing/crossbow/branches/all?query=actions-044cc0b452)
|Task|Status|
|----|------|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17041306257/job/48305467308)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3233238661
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3195700478
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3195707548
Revision: 85a2071aae01eeda65449b35599c13ee5c3606f7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-53ecca2d5e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-53ecca2d5e)
|Task|Status|
|----|------|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17035583722/job/48287172495)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292150480
Revision: a24190d14e4fe0966216efd33ed5e52ce1cc155d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f88998a968](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f88998a968)
|Task|Status|
|----|------|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17734599899/job/50393185788)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292138078
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3266587677
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3266762197
No, we're really running the Python tests here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3293072531
The failing wheel builds also failed on the nightlies. Will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on code in PR #47249:
URL: https://github.com/apache/arrow/pull/47249#discussion_r2245824888
##########
cpp/src/arrow/compute/kernels/scalar_if_else_test.cc:
##########
@@ -3028,6 +3028,12 @@ TEST(TestCoalesce, Boolean) {
ArrayFromJSON(type, "[true, true, false, true]"));
CheckScalar("coalesce", {scalar1, values1},
ArrayFromJSON(type, "[false, false, false, false]"));
+
+ // Regression test from https://github.com/apache/arrow/issues/47234
+ auto values_with_null = ArrayFromJSON(type, "[true, false, false, false, false, null]");
+ auto expected = ArrayFromJSON(type, "[true, false, false, false, false, true]");
+ auto scalar2 = ScalarFromJSON(type, "true");
+ CheckScalar("coalesce", {values_with_null, scalar2}, expected);
Review Comment:
@amoeba following your repro I'm trying the same in cpp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292149292
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292715557
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3266596153
Revision: a24190d14e4fe0966216efd33ed5e52ce1cc155d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ffeb60e918](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ffeb60e918)
|Task|Status|
|----|------|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17554150585/job/49853805929)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3266615608
Perhaps this requires https://github.com/apache/arrow/pull/47455 for the cpp regression test? Currently, no cpp tests are running on Windows CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3266549038
Revision: 483d497af2307270d99e58eea292e39b50520292
Submitted crossbow builds: [ursacomputing/crossbow @ actions-731c5e1702](https://github.com/ursacomputing/crossbow/branches/all?query=actions-731c5e1702)
|Task|Status|
|----|------|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17553798077/job/49852614431)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3233245789
Revision: 61913132ee21b589a1f1baddbc6df9f05488ef52
Submitted crossbow builds: [ursacomputing/crossbow @ actions-184d8e9469](https://github.com/ursacomputing/crossbow/branches/all?query=actions-184d8e9469)
|Task|Status|
|----|------|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17295339788/job/49092052760)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3144005177
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47249:
URL: https://github.com/apache/arrow/pull/47249#discussion_r2281695488
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -1952,6 +1952,48 @@ def test_fill_null_chunked_array(arrow_type):
assert result.equals(expected)
+def test_fill_null_windows_regression1():
+ arr = pa.array([True, False, False, False, False, None])
+ s = pa.scalar(True, type=pa.bool_())
+
+ result = pa.compute.call_function("coalesce", [arr, s])
+ expected = pa.array([True, False, False, False, False, True])
+
+ assert result.equals(expected)
+
+
+def test_fill_null_windows_regression2():
+ arr = pa.array([True, False, False, False, False, None])
+ s = True
+
+ result = pa.compute.call_function("coalesce", [arr, s])
+ expected = pa.array([True, False, False, False, False, True])
+
+ assert result.equals(expected)
+
+
+def test_fill_null_windows_regression4():
+ ty = pa.int64()
+ arr = pa.array([1, 2, 2, 2, 2, None], type=ty)
+ s = pa.scalar(1, type=ty)
+
+ result = pa.compute.call_function("coalesce", [arr, s])
+ expected = pa.array([1, 2, 2, 2, 2, 1], type=ty)
Review Comment:
```suggestion
arr = pa.array([1, 2, 3, 4, 5, None], type=ty)
s = pa.scalar(42, type=ty)
result = pa.compute.call_function("coalesce", [arr, s])
expected = pa.array([1, 2, 3, 4, 5, 42], type=ty)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292728864
Let's check that all wheel builds are ok now. If ok, then this PR will be mergeable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292161448
Revision: 289eea86dd613d52b8fefe119e43732be259f706
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2547cd8dd3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2547cd8dd3)
|Task|Status|
|----|------|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17734666673/job/50393401449)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3196696431
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292139154
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292727839
Revision: 24e90ddb2f06603ef61c8a89506ba4e9b0ad5564
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2d68d9e6cc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2d68d9e6cc)
|Task|Status|
|----|------|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993194/job/50404597539)|
|wheel-macos-monterey-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737991798/job/50404592680)|
|wheel-macos-monterey-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993532/job/50404600103)|
|wheel-macos-monterey-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992148/job/50404594022)|
|wheel-macos-monterey-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992170/job/50404593725)|
|wheel-macos-monterey-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737991816/job/50404593419)|
|wheel-macos-monterey-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737991989/job/50404593395)|
|wheel-macos-monterey-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993518/job/50404598677)|
|wheel-macos-monterey-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992411/job/50404594895)|
|wheel-macos-monterey-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992944/job/50404596527)|
|wheel-macos-monterey-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993139/job/50404597293)|
|wheel-manylinux-2-28-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992499/job/50404595147)|
|wheel-manylinux-2-28-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737991787/job/50404592738)|
|wheel-manylinux-2-28-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992923/job/50404596464)|
|wheel-manylinux-2-28-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992733/job/50404596272)|
|wheel-manylinux-2-28-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993044/job/50404597029)|
|wheel-manylinux-2-28-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992390/job/50404594940)|
|wheel-manylinux-2-28-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993361/job/50404598170)|
|wheel-manylinux-2-28-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993234/job/50404597845)|
|wheel-manylinux-2-28-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993169/job/50404597448)|
|wheel-manylinux-2-28-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992985/job/50404596815)|
|wheel-musllinux-1-2-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992360/job/50404594628)|
|wheel-musllinux-1-2-cp310-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737991954/job/50404593211)|
|wheel-musllinux-1-2-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992697/job/50404595738)|
|wheel-musllinux-1-2-cp311-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992977/job/50404596871)|
|wheel-musllinux-1-2-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993706/job/50404599749)|
|wheel-musllinux-1-2-cp312-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992644/job/50404595522)|
|wheel-musllinux-1-2-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992195/job/50404593913)|
|wheel-musllinux-1-2-cp313-cp313-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993077/job/50404597116)|
|wheel-musllinux-1-2-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993173/job/50404597526)|
|wheel-musllinux-1-2-cp313-cp313t-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993445/job/50404598477)|
|wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737991913/job/50404593567)|
|wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992973/job/50404596663)|
|wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993353/job/50404598174)|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737993316/job/50404597933)|
|wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17737992492/job/50404595281)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292725422
:warning: GitHub issue #47234 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3266540448
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3140196241
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3197027698
Revision: 61913132ee21b589a1f1baddbc6df9f05488ef52
Submitted crossbow builds: [ursacomputing/crossbow @ actions-28a873a6f2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-28a873a6f2)
|Task|Status|
|----|------|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17042547246/job/48309737650)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47249:
URL: https://github.com/apache/arrow/pull/47249#discussion_r2281697114
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -1952,6 +1952,48 @@ def test_fill_null_chunked_array(arrow_type):
assert result.equals(expected)
+def test_fill_null_windows_regression1():
+ arr = pa.array([True, False, False, False, False, None])
+ s = pa.scalar(True, type=pa.bool_())
+
+ result = pa.compute.call_function("coalesce", [arr, s])
+ expected = pa.array([True, False, False, False, False, True])
+
+ assert result.equals(expected)
+
+
+def test_fill_null_windows_regression2():
+ arr = pa.array([True, False, False, False, False, None])
+ s = True
+
+ result = pa.compute.call_function("coalesce", [arr, s])
+ expected = pa.array([True, False, False, False, False, True])
+
+ assert result.equals(expected)
+
+
+def test_fill_null_windows_regression4():
+ ty = pa.int64()
+ arr = pa.array([1, 2, 2, 2, 2, None], type=ty)
+ s = pa.scalar(1, type=ty)
+
+ result = pa.compute.call_function("coalesce", [arr, s])
+ expected = pa.array([1, 2, 2, 2, 2, 1], type=ty)
+
+ assert result.equals(expected)
+
+
+def test_fill_null_windows_regression5():
+ ty = pa.int32()
+ arr = pa.array([1, 2, 2, 2, 2, None], type=ty)
+ s = pa.scalar(1, type=ty)
+
+ result = pa.compute.call_function("coalesce", [arr, s])
+ expected = pa.array([1, 2, 2, 2, 2, 1], type=ty)
Review Comment:
```suggestion
arr = pa.array([1, 2, 3, 4, 5, None], type=ty)
s = pa.scalar(42, type=ty)
result = pa.compute.call_function("coalesce", [arr, s])
expected = pa.array([1, 2, 3, 4, 5, 42], type=ty)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3197014066
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292154382
Revision: a24190d14e4fe0966216efd33ed5e52ce1cc155d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-569da0898e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-569da0898e)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607723/job/50393211927)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607882/job/50393212422)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607293/job/50393210548)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/17734608387/job/50393213690)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607777/job/50393212757)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607544/job/50393211360)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607435/job/50393210873)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17734608040/job/50393212694)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/17734606872/job/50393209018)|
|test-fedora-42-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607062/job/50393209999)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607044/job/50393209546)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607999/job/50393212581)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607845/job/50393212093)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607491/job/50393211124)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607816/job/50393212690)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607243/job/50393210185)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607822/job/50393212055)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/17734608024/job/50393212502)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/17734606957/job/50393209423)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/17734607869/job/50393214046)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/17734606769/job/50393208574)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3292167573
Revision: 289eea86dd613d52b8fefe119e43732be259f706
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f189892110](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f189892110)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/17734703993/job/50393515192)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/17734703727/job/50393514612)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704746/job/50393517519)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/17734703726/job/50393514499)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17734703855/job/50393514715)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/17734703762/job/50393514935)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704078/job/50393515400)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704703/job/50393517333)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704534/job/50393517818)|
|test-fedora-42-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704123/job/50393515491)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17734703716/job/50393514463)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704465/job/50393516638)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704461/job/50393516532)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704540/job/50393516855)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/17734703995/job/50393515310)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704543/job/50393517111)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704527/job/50393517338)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704841/job/50393517697)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704147/job/50393517469)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/17734703937/job/50393515233)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/17734704455/job/50393516579)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] Add test for fill_null regression on Windows [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3294358971
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4630313644e7b3f74fcd5fd0398e0d945fac89e7.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/50442486161) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47234: [C++][Python] fill_null regression on windows [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47249:
URL: https://github.com/apache/arrow/pull/47249#issuecomment-3233240034
(retrying a new build, who knows, perhaps something was fixed?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org