You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/09/26 07:23:23 UTC
Review Request 26070: Alerts: Reschedule Individual Alerts on Agents
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26070/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-7508
https://issues.apache.org/jira/browse/AMBARI-7508
Repository: ambari
Description
-------
In addition to the global UUID, each AlertDefinition should be sent down to the agents with its own UUID in order to reschedule only those individual definitions that changed.
Once receiving the updated definitions, only those definitions with UUID changes should be rescheduled.
This patch addresses the following:
- JPA bug causing staleness in some nested entities
- ElipseLink update to fix above bug
- UUIDs on definitions
- Rescheduling only changed definitions
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 7cce533a2a7a701e4c7b26cdf5686d4f7b332689
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b22938dc66bede523f4beef33efd57962d81263c
ambari-agent/src/main/python/ambari_agent/alerts/collector.py 7249449128286d962051da0d2bb0589543169e43
ambari-agent/src/test/python/ambari_agent/TestAlerts.py 5dc45b56df7de6167400c8130e222fcc7208e8c3
ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json ad52abc91a19dd1bcc3f2232aaeead6d16d03570
ambari-project/pom.xml 58e2e8fbf82f380e1829f587e477c9b8644e157d
ambari-server/pom.xml 5ac76f988e075c496436a44bffa13f59d04018c7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java fc51dddfde15d04b7de28a31fa09c16520d6caf6
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionDeleteEvent.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 6cf752e3c82bdb3528065dbfbaafda82f5a4e8a4
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertLifecycleListener.java 43d4b353d5b642ea39fe9d13af193b0379e1466f
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java e87ba7db73fa4ba3fc1052f28cc43d39007f55e4
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 075ee04ee55abc795ed0523960349ac7caf170f8
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java a28b44839651c9412e95c4c24eefd03bb8d3ba02
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 8548fdafecec7135e9affe2e09f1d799fa6cba8b
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 1cc9bccd504020a76dd104c6e07dcceed68a2837
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 04f20f9b10c21fb750fa674463d609fec4ba0160
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java 5058e91415deab01dc4ec15eef42cdf47df29757
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java 4f6a9a3762aae6d992dfb78a430be4478561bc7a
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 9ea039c3df17fa23476ee36a44028fac5756f2e8
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java 558361706cc830087cb42af10b5ec5bc898cccc4
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java 4d182cc32230b1739111b30a80029c0c90a3af33
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java fd18134e6c0d20c71a41c8d368246dff0d2f4cb7
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java 482b5ef1c623406b430023ad517e689084ac2efb
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java 312f2977704521231388e72bbd9dd43ae4bbfba9
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java 85a6e9befe5ede993580b639fe8dc72b64697f98
Diff: https://reviews.apache.org/r/26070/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 26070: Alerts: Reschedule Individual Alerts on
Agents
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26070/#review54690
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Sept. 26, 2014, 1:23 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26070/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 1:23 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-7508
> https://issues.apache.org/jira/browse/AMBARI-7508
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In addition to the global UUID, each AlertDefinition should be sent down to the agents with its own UUID in order to reschedule only those individual definitions that changed.
>
> Once receiving the updated definitions, only those definitions with UUID changes should be rescheduled.
>
> This patch addresses the following:
>
> - JPA bug causing staleness in some nested entities
> - ElipseLink update to fix above bug
> - UUIDs on definitions
> - Rescheduling only changed definitions
> - Deleting alert definition unschedules just that 1 definition
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 7cce533a2a7a701e4c7b26cdf5686d4f7b332689
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b22938dc66bede523f4beef33efd57962d81263c
> ambari-agent/src/main/python/ambari_agent/alerts/collector.py 7249449128286d962051da0d2bb0589543169e43
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 5dc45b56df7de6167400c8130e222fcc7208e8c3
> ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json ad52abc91a19dd1bcc3f2232aaeead6d16d03570
> ambari-project/pom.xml 58e2e8fbf82f380e1829f587e477c9b8644e157d
> ambari-server/pom.xml 5ac76f988e075c496436a44bffa13f59d04018c7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java fc51dddfde15d04b7de28a31fa09c16520d6caf6
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionDeleteEvent.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 6cf752e3c82bdb3528065dbfbaafda82f5a4e8a4
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertLifecycleListener.java 43d4b353d5b642ea39fe9d13af193b0379e1466f
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java e87ba7db73fa4ba3fc1052f28cc43d39007f55e4
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 075ee04ee55abc795ed0523960349ac7caf170f8
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java a28b44839651c9412e95c4c24eefd03bb8d3ba02
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 8548fdafecec7135e9affe2e09f1d799fa6cba8b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 1cc9bccd504020a76dd104c6e07dcceed68a2837
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 04f20f9b10c21fb750fa674463d609fec4ba0160
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java 5058e91415deab01dc4ec15eef42cdf47df29757
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java 4f6a9a3762aae6d992dfb78a430be4478561bc7a
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 9ea039c3df17fa23476ee36a44028fac5756f2e8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java 558361706cc830087cb42af10b5ec5bc898cccc4
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java 4d182cc32230b1739111b30a80029c0c90a3af33
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java fd18134e6c0d20c71a41c8d368246dff0d2f4cb7
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java 482b5ef1c623406b430023ad517e689084ac2efb
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java 312f2977704521231388e72bbd9dd43ae4bbfba9
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java 85a6e9befe5ede993580b639fe8dc72b64697f98
>
> Diff: https://reviews.apache.org/r/26070/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 26070: Alerts: Reschedule Individual Alerts on
Agents
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Sept. 26, 2014, 12:04 p.m., Nate Cole wrote:
> >
Thanks for the review!
> On Sept. 26, 2014, 12:04 p.m., Nate Cole wrote:
> > ambari-project/pom.xml, lines 58-60
> > <https://reviews.apache.org/r/26070/diff/1/?file=705934#file705934line58>
> >
> > What is this trickery?
http://wiki.eclipse.org/EclipseLink/Maven
The EclipseLink project has switched to publishing its builds through oss.sonatype org during the 2.4.2/2.5.0 development. The staging repo will provide access to SNAPSHOT and named milestone and release candidate builds. To access these use:
<repository>
<id>oss.sonatype.org</id>
<name>OSS Sonatype Staging</name>
<url>https://oss.sonatype.org/content/groups/staging</url>
</repository>
When the 2.4.2 and above releases are finalized they will be published to Maven Central where no additional repository configuration will be required.
> On Sept. 26, 2014, 12:04 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertLifecycleListener.java, line 47
> > <https://reviews.apache.org/r/26070/diff/1/?file=705939#file705939line47>
> >
> > Copy/Paste, or did you want to use another class' logger?
Eagle Eye! One reason I really, really dislike log4j/slf4j is that you have to assign a class to a logger. Fixed.
> On Sept. 26, 2014, 12:04 p.m., Nate Cole wrote:
> > ambari-server/pom.xml, lines 1460-1462
> > <https://reviews.apache.org/r/26070/diff/1/?file=705935#file705935line1460>
> >
> > See above
EclipseLink's doc (above) states this is how their maven repo is defined now.
> On Sept. 26, 2014, 12:04 p.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/alerts/collector.py, lines 38-56
> > <https://reviews.apache.org/r/26070/diff/1/?file=705931#file705931line38>
> >
> > Should we be keying buckets using uuid instead? The original code didn't use name for anything, but using uuid as the dict key would remove the need to loop when removing (saving 0.002 seconds)
I think that keeping the key-by-cluster will be useful in about 15 years when a single agent supports multiple cluster components. This is the collector, so I can see the value in being able to easily pull out all alerts by cluster first.
UUIDs also change, so using them as a key is probably not a good thing as it would require us to make 2 passes to remove outdated UUIDs.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26070/#review54684
-----------------------------------------------------------
On Sept. 26, 2014, 1:23 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26070/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 1:23 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-7508
> https://issues.apache.org/jira/browse/AMBARI-7508
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In addition to the global UUID, each AlertDefinition should be sent down to the agents with its own UUID in order to reschedule only those individual definitions that changed.
>
> Once receiving the updated definitions, only those definitions with UUID changes should be rescheduled.
>
> This patch addresses the following:
>
> - JPA bug causing staleness in some nested entities
> - ElipseLink update to fix above bug
> - UUIDs on definitions
> - Rescheduling only changed definitions
> - Deleting alert definition unschedules just that 1 definition
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 7cce533a2a7a701e4c7b26cdf5686d4f7b332689
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b22938dc66bede523f4beef33efd57962d81263c
> ambari-agent/src/main/python/ambari_agent/alerts/collector.py 7249449128286d962051da0d2bb0589543169e43
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 5dc45b56df7de6167400c8130e222fcc7208e8c3
> ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json ad52abc91a19dd1bcc3f2232aaeead6d16d03570
> ambari-project/pom.xml 58e2e8fbf82f380e1829f587e477c9b8644e157d
> ambari-server/pom.xml 5ac76f988e075c496436a44bffa13f59d04018c7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java fc51dddfde15d04b7de28a31fa09c16520d6caf6
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionDeleteEvent.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 6cf752e3c82bdb3528065dbfbaafda82f5a4e8a4
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertLifecycleListener.java 43d4b353d5b642ea39fe9d13af193b0379e1466f
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java e87ba7db73fa4ba3fc1052f28cc43d39007f55e4
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 075ee04ee55abc795ed0523960349ac7caf170f8
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java a28b44839651c9412e95c4c24eefd03bb8d3ba02
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 8548fdafecec7135e9affe2e09f1d799fa6cba8b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 1cc9bccd504020a76dd104c6e07dcceed68a2837
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 04f20f9b10c21fb750fa674463d609fec4ba0160
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java 5058e91415deab01dc4ec15eef42cdf47df29757
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java 4f6a9a3762aae6d992dfb78a430be4478561bc7a
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 9ea039c3df17fa23476ee36a44028fac5756f2e8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java 558361706cc830087cb42af10b5ec5bc898cccc4
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java 4d182cc32230b1739111b30a80029c0c90a3af33
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java fd18134e6c0d20c71a41c8d368246dff0d2f4cb7
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java 482b5ef1c623406b430023ad517e689084ac2efb
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java 312f2977704521231388e72bbd9dd43ae4bbfba9
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java 85a6e9befe5ede993580b639fe8dc72b64697f98
>
> Diff: https://reviews.apache.org/r/26070/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 26070: Alerts: Reschedule Individual Alerts on
Agents
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26070/#review54684
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/alerts/collector.py
<https://reviews.apache.org/r/26070/#comment94914>
Should we be keying buckets using uuid instead? The original code didn't use name for anything, but using uuid as the dict key would remove the need to loop when removing (saving 0.002 seconds)
ambari-project/pom.xml
<https://reviews.apache.org/r/26070/#comment94915>
What is this trickery?
ambari-server/pom.xml
<https://reviews.apache.org/r/26070/#comment94917>
See above
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertLifecycleListener.java
<https://reviews.apache.org/r/26070/#comment94919>
Copy/Paste, or did you want to use another class' logger?
- Nate Cole
On Sept. 26, 2014, 1:23 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26070/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 1:23 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-7508
> https://issues.apache.org/jira/browse/AMBARI-7508
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In addition to the global UUID, each AlertDefinition should be sent down to the agents with its own UUID in order to reschedule only those individual definitions that changed.
>
> Once receiving the updated definitions, only those definitions with UUID changes should be rescheduled.
>
> This patch addresses the following:
>
> - JPA bug causing staleness in some nested entities
> - ElipseLink update to fix above bug
> - UUIDs on definitions
> - Rescheduling only changed definitions
> - Deleting alert definition unschedules just that 1 definition
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 7cce533a2a7a701e4c7b26cdf5686d4f7b332689
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b22938dc66bede523f4beef33efd57962d81263c
> ambari-agent/src/main/python/ambari_agent/alerts/collector.py 7249449128286d962051da0d2bb0589543169e43
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 5dc45b56df7de6167400c8130e222fcc7208e8c3
> ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json ad52abc91a19dd1bcc3f2232aaeead6d16d03570
> ambari-project/pom.xml 58e2e8fbf82f380e1829f587e477c9b8644e157d
> ambari-server/pom.xml 5ac76f988e075c496436a44bffa13f59d04018c7
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java fc51dddfde15d04b7de28a31fa09c16520d6caf6
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionDeleteEvent.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 6cf752e3c82bdb3528065dbfbaafda82f5a4e8a4
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertLifecycleListener.java 43d4b353d5b642ea39fe9d13af193b0379e1466f
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java e87ba7db73fa4ba3fc1052f28cc43d39007f55e4
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 075ee04ee55abc795ed0523960349ac7caf170f8
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java a28b44839651c9412e95c4c24eefd03bb8d3ba02
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 8548fdafecec7135e9affe2e09f1d799fa6cba8b
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 1cc9bccd504020a76dd104c6e07dcceed68a2837
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 04f20f9b10c21fb750fa674463d609fec4ba0160
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java 5058e91415deab01dc4ec15eef42cdf47df29757
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java 4f6a9a3762aae6d992dfb78a430be4478561bc7a
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 9ea039c3df17fa23476ee36a44028fac5756f2e8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java 558361706cc830087cb42af10b5ec5bc898cccc4
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java 4d182cc32230b1739111b30a80029c0c90a3af33
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java fd18134e6c0d20c71a41c8d368246dff0d2f4cb7
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java 482b5ef1c623406b430023ad517e689084ac2efb
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java 312f2977704521231388e72bbd9dd43ae4bbfba9
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java 85a6e9befe5ede993580b639fe8dc72b64697f98
>
> Diff: https://reviews.apache.org/r/26070/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 26070: Alerts: Reschedule Individual Alerts on
Agents
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26070/
-----------------------------------------------------------
(Updated Sept. 26, 2014, 1:23 a.m.)
Review request for Ambari and Nate Cole.
Bugs: AMBARI-7508
https://issues.apache.org/jira/browse/AMBARI-7508
Repository: ambari
Description (updated)
-------
In addition to the global UUID, each AlertDefinition should be sent down to the agents with its own UUID in order to reschedule only those individual definitions that changed.
Once receiving the updated definitions, only those definitions with UUID changes should be rescheduled.
This patch addresses the following:
- JPA bug causing staleness in some nested entities
- ElipseLink update to fix above bug
- UUIDs on definitions
- Rescheduling only changed definitions
- Deleting alert definition unschedules just that 1 definition
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 7cce533a2a7a701e4c7b26cdf5686d4f7b332689
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py b22938dc66bede523f4beef33efd57962d81263c
ambari-agent/src/main/python/ambari_agent/alerts/collector.py 7249449128286d962051da0d2bb0589543169e43
ambari-agent/src/test/python/ambari_agent/TestAlerts.py 5dc45b56df7de6167400c8130e222fcc7208e8c3
ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json ad52abc91a19dd1bcc3f2232aaeead6d16d03570
ambari-project/pom.xml 58e2e8fbf82f380e1829f587e477c9b8644e157d
ambari-server/pom.xml 5ac76f988e075c496436a44bffa13f59d04018c7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java fc51dddfde15d04b7de28a31fa09c16520d6caf6
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionDeleteEvent.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 6cf752e3c82bdb3528065dbfbaafda82f5a4e8a4
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertLifecycleListener.java 43d4b353d5b642ea39fe9d13af193b0379e1466f
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/AlertReceivedListener.java e87ba7db73fa4ba3fc1052f28cc43d39007f55e4
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 075ee04ee55abc795ed0523960349ac7caf170f8
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java a28b44839651c9412e95c4c24eefd03bb8d3ba02
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 8548fdafecec7135e9affe2e09f1d799fa6cba8b
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 1cc9bccd504020a76dd104c6e07dcceed68a2837
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 04f20f9b10c21fb750fa674463d609fec4ba0160
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java 5058e91415deab01dc4ec15eef42cdf47df29757
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java 4f6a9a3762aae6d992dfb78a430be4478561bc7a
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 9ea039c3df17fa23476ee36a44028fac5756f2e8
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java 558361706cc830087cb42af10b5ec5bc898cccc4
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java 4d182cc32230b1739111b30a80029c0c90a3af33
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java fd18134e6c0d20c71a41c8d368246dff0d2f4cb7
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java 482b5ef1c623406b430023ad517e689084ac2efb
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java 312f2977704521231388e72bbd9dd43ae4bbfba9
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java 85a6e9befe5ede993580b639fe8dc72b64697f98
Diff: https://reviews.apache.org/r/26070/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley