[GitHub] [couchdb] chewbranca commented on a change in pull request #2519: Fix b3 header

[GitBox <gi...@apache.org>]

chewbranca commented on a change in pull request #2519: Fix b3 header
URL: https://github.com/apache/couchdb/pull/2519#discussion_r374849374
 
 

 ##########
 File path: src/chttpd/test/exunit/tracing_test.exs
 ##########
 @@ -0,0 +1,101 @@
+defmodule Couch.Test.OpenTracing do
+  use Couch.Test.ExUnit.Case
+  alias Couch.Test.Setup
+  alias Couch.Test.Setup.Step
+  alias Couch.Test.Utils
+  import Couch.DBTest, only: [retry_until: 1]
+
+  defp create_admin(user_name, password) do
+    hashed = String.to_charlist(:couch_passwords.hash_admin_password(password))
+    :config.set('admins', String.to_charlist(user_name), hashed, false)
+  end
 
 Review comment:
   It seems like the `create_admin` function along with some of the other function below would be useful to have in the shared Couch library. Any particular reason to not put these functions into the `couch.ex` module?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services