DO NOT REPLY [Bug 9456] New: - Problem saving server.xml file: invalid XML markup

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9456>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9456

Problem saving server.xml file: invalid XML markup

           Summary: Problem saving server.xml file: invalid XML markup
           Product: Tomcat 4
           Version: 4.1.2
          Platform: PC
        OS/Version: Windows NT/2K
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Webapps:Administration
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: richard@thehusses.freeserve.co.uk


I have been having a little trouble with the new admin application in 4.1.2 
(which is /very/ nice, BTW). I added an access log valve to localhost, using 
the 'common' log format which is equivalent to the pattern %h %l %u %t "%r" %s %
b

Unfortunately, when you commit the changes this results in a server.xml file 
that is not valid XML. I am getting the following entry in server.xml:

  <Valve className="org.apache.catalina.valves.AccessLogValve" debug="0"
   prefix="access_log.localhost." directory="logs"
   pattern="%h %l %u %t "%r" %s %b" resolveHosts="false" suffix=".txt"/>

Note the quote signs within the pattern attribute; the StandardServerMBean 
storeAttributes(PrintWriter, boolean, Object) method is simply writing out the 
attribute value without any escaping &c.

But I also wonder whether it would be worth changing AccessLogValve so that its 
getPattern() method returns "common" or "combined" for those shortcuts, rather 
than expanding them to "%h %l %u %t \"%r\" %s %b" and "%h %l %u %t \"%r\" %s %b 
\"%{Referer}i\" \"%{User-Agent}i\"" ? This would make saved server.xml files 
easier to read; the present behaviour is a little disconcerting.

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>