You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/03/26 23:08:22 UTC
Review Request 19699: Add support to assign all threads of a process to a
cgroup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19699/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
Add support to assign all threads of a process to a cgroup.
Diffs
-----
src/linux/cgroups.hpp 6056e3ae59ed813d75b1bb46b276872530155ec7
src/linux/cgroups.cpp eff15af417f3827b4a1f73770b98dc9fccbc397e
Diff: https://reviews.apache.org/r/19699/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 19699: Add support to assign all threads of a process to
a cgroup.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19699/
-----------------------------------------------------------
(Updated March 26, 2014, 11:56 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Addressed Vinod's comments.
Repository: mesos-git
Description
-------
Add support to assign all threads of a process to a cgroup.
Diffs (updated)
-----
src/linux/cgroups.hpp 6056e3ae59ed813d75b1bb46b276872530155ec7
src/linux/cgroups.cpp eff15af417f3827b4a1f73770b98dc9fccbc397e
Diff: https://reviews.apache.org/r/19699/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 19699: Add support to assign all threads of a process to
a cgroup.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19699/#review38673
-----------------------------------------------------------
Ship it!
src/linux/cgroups.hpp
<https://reviews.apache.org/r/19699/#comment70937>
s/MAX_// to be consistent?
src/linux/cgroups.hpp
<https://reviews.apache.org/r/19699/#comment70936>
s/with/will/
src/linux/cgroups.cpp
<https://reviews.apache.org/r/19699/#comment70943>
kill new line.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/19699/#comment70946>
s/threadsToMove/move/?
src/linux/cgroups.cpp
<https://reviews.apache.org/r/19699/#comment70939>
kill new line.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/19699/#comment70940>
kill new line.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/19699/#comment70941>
kill new line.
- Vinod Kone
On March 26, 2014, 10:25 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19699/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 10:25 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add support to assign all threads of a process to a cgroup.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 6056e3ae59ed813d75b1bb46b276872530155ec7
> src/linux/cgroups.cpp eff15af417f3827b4a1f73770b98dc9fccbc397e
>
> Diff: https://reviews.apache.org/r/19699/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 19699: Add support to assign all threads of a process to
a cgroup.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19699/
-----------------------------------------------------------
(Updated March 26, 2014, 10:25 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos-git
Description
-------
Add support to assign all threads of a process to a cgroup.
Diffs (updated)
-----
src/linux/cgroups.hpp 6056e3ae59ed813d75b1bb46b276872530155ec7
src/linux/cgroups.cpp eff15af417f3827b4a1f73770b98dc9fccbc397e
Diff: https://reviews.apache.org/r/19699/diff/
Testing
-------
Thanks,
Ian Downes