You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/05 15:52:27 UTC

[GitHub] yanghua commented on a change in pull request #6648: [FLINK-10261][table] fix insert into with order by

yanghua commented on a change in pull request #6648: [FLINK-10261][table] fix insert into with order by
URL: https://github.com/apache/flink/pull/6648#discussion_r215327517
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/validation/SortValidationTest.scala
 ##########
 @@ -54,4 +53,12 @@ class SortValidationTest extends TableTestBase {
     val sqlQuery = "SELECT a FROM MyTable LIMIT 3"
     streamUtil.verifySql(sqlQuery, "")
   }
+
+  // test should fail because time is not order field
+  @Test(expected = classOf[TableException])
+  def testNonTimeSorting(): Unit = {
+
 
 Review comment:
   Remove this empty line looks better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services