You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/04/01 23:53:20 UTC
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request
#3436: Traffic router add https
rawlinp commented on a change in pull request #3436: Traffic router add https
URL: https://github.com/apache/trafficcontrol/pull/3436#discussion_r271078960
##########
File path: lib/go-tc/crconfig.go
##########
@@ -67,16 +67,17 @@ type CRConfigTTL struct {
type CRConfigRouterStatus string
type CRConfigRouter struct {
- APIPort *string `json:"api.port,omitempty"`
- FQDN *string `json:"fqdn,omitempty"`
- HTTPSPort *int `json:"httpsPort"`
- HashCount *int `json:"hashCount,omitempty"`
- IP *string `json:"ip,omitempty"`
- IP6 *string `json:"ip6,omitempty"`
- Location *string `json:"location,omitempty"`
- Port *int `json:"port,omitempty"`
- Profile *string `json:"profile,omitempty"`
- ServerStatus *CRConfigRouterStatus `json:"status,omitempty"`
+ APIPort *string `json:"api.port,omitempty"`
+ SecureAPIPort *string `json:"secure.api.port,omitempty"`
Review comment:
nit: I don't really mind this, but I knows some people prefer the fields to be sorted alphabetically
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services