[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #915: [WIP] Test new marshaller

[GitBox <gi...@apache.org>]

AMashenkov commented on code in PR #915:
URL: https://github.com/apache/ignite-3/pull/915#discussion_r933371780


##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/util/JDKMarshaller.java:
##########
@@ -54,4 +60,37 @@ public class JDKMarshaller implements Marshaller {
             throw new Error(e);
         }
     }
+
+    /** */
+    public static class NewMarshaller implements Marshaller {
+        /** */
+        private final ClassDescriptorRegistry registry = new ClassDescriptorRegistry();
+
+        /** */
+        private final ClassDescriptorFactory factory = new ClassDescriptorFactory(registry);
+
+        /** */
+        private final UserObjectMarshaller uom = new DefaultUserObjectMarshaller(registry, factory);
+
+        /** {@inheritDoc} */
+        @Override
+        public byte[] marshall(Object o) {

Review Comment:
   Let's use correct names 'marshal'/'unmarshal' for methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org