You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2012/10/01 23:54:39 UTC
svn commit: r1392652 -
/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
Author: markt
Date: Mon Oct 1 21:54:38 2012
New Revision: 1392652
URL: http://svn.apache.org/viewvc?rev=1392652&view=rev
Log:
Fix some warnings:
- Findbugs - not serializable
- Eclipse - unchecked conversion
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java?rev=1392652&r1=1392651&r2=1392652&view=diff
==============================================================================
--- tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java (original)
+++ tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java Mon Oct 1 21:54:38 2012
@@ -901,9 +901,10 @@ public class PoolProperties implements P
}
- public static class InterceptorDefinition {
+ public static class InterceptorDefinition implements Serializable {
+ private static final long serialVersionUID = 1L;
protected String className;
- protected Map<String,InterceptorProperty> properties = new HashMap<String,InterceptorProperty>();
+ protected Map<String,InterceptorProperty> properties = new HashMap<>();
protected volatile Class<?> clazz = null;
public InterceptorDefinition(String className) {
this.className = className;
@@ -930,6 +931,7 @@ public class PoolProperties implements P
return properties;
}
+ @SuppressWarnings("unchecked")
public Class<? extends JdbcInterceptor> getInterceptorClass() throws ClassNotFoundException {
if (clazz==null) {
if (getClassName().indexOf(".")<0) {
@@ -948,7 +950,8 @@ public class PoolProperties implements P
}
}
- public static class InterceptorProperty {
+ public static class InterceptorProperty implements Serializable {
+ private static final long serialVersionUID = 1L;
String name;
String value;
public InterceptorProperty(String name, String value) {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org