You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "frankcash (via GitHub)" <gi...@apache.org> on 2023/09/22 11:33:59 UTC

[GitHub] [airflow] frankcash commented on a diff in pull request #34533: Defined constants for repo routes in databricks hook

frankcash commented on code in PR #34533:
URL: https://github.com/apache/airflow/pull/34533#discussion_r1334262330


##########
airflow/providers/databricks/hooks/databricks.py:
##########
@@ -526,7 +530,7 @@ def update_repo(self, repo_id: str, json: dict[str, Any]) -> dict:
         :param json: payload
         :return: metadata from update
         """
-        repos_endpoint = ("PATCH", f"api/2.0/repos/{repo_id}")
+        repos_endpoint = UPDATE_REPO_ENDPOINT[1].format(repo_id=repo_id)

Review Comment:
   Yeah, it looks like you are setting repos endpoint to just the endpoint will which not work for [self._do_api_calls ](https://github.com/apache/airflow/blob/24394ee79df085edf8502894ceb82aa0150147bf/airflow/providers/databricks/hooks/databricks_base.py#L552-L572) as it is expecting a tuple



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org