You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/03/08 17:24:40 UTC

[GitHub] [hive] aasha opened a new pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

aasha opened a new pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945
 
 
   …ternal.table is enabled

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391374054
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadTable.java
 ##########
 @@ -191,7 +192,7 @@ private void newTableTasks(ImportTableDesc tblDesc, Task<?> tblRootTask, TableLo
     } else {
       tblRootTask.addDependentTask(createTableTask);
     }
-    if (replicationSpec.isMetadataOnly()) {
+    if (replicationSpec.isMetadataOnly() || Utils.shouldDumpMetaDataOnlyForExternalTables(table, context.hiveConf)) {
       tracker.addTask(tblRootTask);
 
 Review comment:
   load time methods ..gets executed using target cluster config

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391440131
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java
 ##########
 @@ -315,7 +325,7 @@ public AuthEntities getAuthEntities() throws SemanticException {
     AuthEntities authEntities = new AuthEntities();
     try {
       // Return if metadata-only
-      if (replicationSpec.isMetadataOnly()) {
+      if (replicationSpec.isMetadataOnly() || replicationSpec.isMetadataOnlyForExternalTables()) {
 
 Review comment:
   This check is wrong as we are dumping the partitions 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391439953
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java
 ##########
 @@ -75,11 +75,20 @@ public TableExport(Paths paths, TableSpec tableSpec, ReplicationSpec replication
         ? null
         : tableSpec;
     this.replicationSpec = replicationSpec;
-    if (this.tableSpec != null && this.tableSpec.tableHandle!=null && (this.tableSpec.tableHandle.isView() ||
-            Utils.shouldDumpMetaDataOnly(this.tableSpec.tableHandle, conf))) {
-      this.replicationSpec.setIsMetadataOnly(true);
-
-      this.tableSpec.tableHandle.setStatsStateLikeNewTable();
+    if (this.tableSpec != null && this.tableSpec.tableHandle!=null) {
+      //If table is view or if should dump metadata only flag used by DAS is set to true
+      //enable isMetadataOnly
+      if (this.tableSpec.tableHandle.isView() || Utils.shouldDumpMetaDataOnly(conf)) {
+        this.tableSpec.tableHandle.setStatsStateLikeNewTable();
+        this.replicationSpec.setIsMetadataOnly(true);
+      }
+      //If table is view or if should dump metadata only for external table flag is set to true
+      //enable isMetadataOnlyForExternalTable
+      if (this.tableSpec.tableHandle.isView()
+              || Utils.shouldDumpMetaDataOnlyForExternalTables(this.tableSpec.tableHandle, conf)) {
+        this.tableSpec.tableHandle.setStatsStateLikeNewTable();
+        this.replicationSpec.setMetadataOnlyForExternalTables(true);
 
 Review comment:
   No where this flag is accessed ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391378963
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
 ##########
 @@ -615,7 +615,8 @@ void dumpTable(String dbName, String tblName, String validTxnList, Path dbRoot,
             exportPaths, tableSpec, tuple.replicationSpec, hiveDb, distCpDoAsUser, conf, mmCtx).write(false);
     replLogger.tableLog(tblName, tableSpec.tableHandle.getTableType());
     if (tableSpec.tableHandle.getTableType().equals(TableType.EXTERNAL_TABLE)
-            || Utils.shouldDumpMetaDataOnly(tuple.object, conf)) {
+            || Utils.shouldDumpMetaDataOnlyForExternalTables(tuple.object, conf)
 
 Review comment:
   This check is not required 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391377407
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java
 ##########
 @@ -189,7 +189,8 @@ public static boolean shouldReplicate(ReplicationSpec replicationSpec, Table tab
     }
 
     // if its metadata only, then dump metadata of non native tables also.
-    if (tableHandle.isNonNative() && !replicationSpec.isMetadataOnly()) {
+    if (tableHandle.isNonNative() && !replicationSpec.isMetadataOnly()
+            && !Utils.shouldDumpMetaDataOnlyForExternalTables(tableHandle, hiveConf)) {
 
 Review comment:
   The check is very specific to DAS ..it includes external table meta data even if external table replication is not enabled ..i am not sure if we can have same for this config also

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391374838
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java
 ##########
 @@ -96,6 +101,7 @@ public TableExport(Paths paths, TableSpec tableSpec, ReplicationSpec replication
       PartitionIterable withPartitions = getPartitions();
       writeMetaData(withPartitions);
       if (!replicationSpec.isMetadataOnly()
+              && !Utils.shouldDumpMetaDataOnlyForExternalTables(tableSpec.tableHandle, conf)
 
 Review comment:
   anyway we are skipping this for external table ..this new check is not required 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391377311
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java
 ##########
 @@ -200,7 +201,8 @@ public static boolean shouldReplicate(ReplicationSpec replicationSpec, Table tab
 
       if (MetaStoreUtils.isExternalTable(tableHandle.getTTable())) {
         boolean shouldReplicateExternalTables = hiveConf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES)
-                || replicationSpec.isMetadataOnly();
+                || replicationSpec.isMetadataOnly()
+                || Utils.shouldDumpMetaDataOnlyForExternalTables(tableHandle, hiveConf);
 
 Review comment:
   The check is very specific to DAS ..it includes external table meta data even if external table replication is not enabled ..i am not sure if we can have same for this config also

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391382551
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSpec.java
 ##########
 @@ -279,6 +280,17 @@ public void setIsMetadataOnly(boolean isMetadataOnly){
     this.isMetadataOnly = isMetadataOnly;
   }
 
+  /**
+   * @return true if this statement refers to metadata-only operation.
+   */
+  public boolean isMetadataOnlyForExternalTables() {
 
 Review comment:
   i think the only change for this patch should be ..if its external table metadata only ..then just dont dump external table data 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391015656
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSpec.java
 ##########
 @@ -279,6 +280,17 @@ public void setIsMetadataOnly(boolean isMetadataOnly){
     this.isMetadataOnly = isMetadataOnly;
   }
 
+  /**
+   * @return true if this statement refers to metadata-only operation.
+   */
+  public boolean isMetadataOnlyForExternalTables() {
+    return isMetadataOnlyForExternalTables;
+  }
+
+  public void setMetadataOnlyForExternalTables(boolean metadataOnlyForExternalTables) {
 
 Review comment:
   this should always be used with table object 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391382165
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
 ##########
 @@ -1224,7 +1225,7 @@ private static void createReplImportTasks(
         dependentTasks = new ArrayList<>(partitionDescs.size());
         for (AlterTableAddPartitionDesc addPartitionDesc : partitionDescs) {
           addPartitionDesc.setReplicationSpec(replicationSpec);
-          if (!replicationSpec.isMetadataOnly()) {
+          if (!replicationSpec.isMetadataOnly() && !Utils.shouldDumpMetaDataOnlyForExternalTables(table, x.getConf())) {
 
 Review comment:
   load time methods

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391378470
 
 

 ##########
 File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java
 ##########
 @@ -167,7 +167,8 @@ public void externalTableReplicationWithDefaultPaths() throws Throwable {
         .run("select country from t2 where country = 'us'")
         .verifyResult("us")
         .run("select country from t2 where country = 'france'")
-        .verifyResult("france");
+        .verifyResult("france")
+        .run("show partitions t2").verifyResults(new String[] {"country=france", "country=india", "country=us"});
 
 Review comment:
   Add tests for incremental load also

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391015656
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSpec.java
 ##########
 @@ -279,6 +280,17 @@ public void setIsMetadataOnly(boolean isMetadataOnly){
     this.isMetadataOnly = isMetadataOnly;
   }
 
+  /**
+   * @return true if this statement refers to metadata-only operation.
+   */
+  public boolean isMetadataOnlyForExternalTables() {
+    return isMetadataOnlyForExternalTables;
+  }
+
+  public void setMetadataOnlyForExternalTables(boolean metadataOnlyForExternalTables) {
 
 Review comment:
   this should always be used with table object 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391015250
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSpec.java
 ##########
 @@ -379,7 +391,7 @@ public String get(KEY key) {
 
   public SCOPE getScope(){
     if (isInReplicationScope()){
-      if (isMetadataOnly()){
+      if (isMetadataOnly() || isMetadataOnlyForExternalTables()){
 
 Review comment:
   No need to change this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391373822
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
 ##########
 @@ -129,7 +130,8 @@ public TaskTracker tasks() throws Exception {
       // existing
       if (table.isPartitioned()) {
         List<AlterTableAddPartitionDesc> partitionDescs = event.partitionDescriptions(tableDesc);
-        if (!event.replicationSpec().isMetadataOnly() && !event.replicationSpec().isMetadataOnlyForExternalTables()
+        if (!event.replicationSpec().isMetadataOnly()
+                && !Utils.shouldDumpMetaDataOnlyForExternalTables(table, context.hiveConf)
 
 Review comment:
   These all are load time functions ..i am not sure if we can use the config ..it should be checked using replicationspec

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391371141
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
 ##########
 @@ -206,7 +208,7 @@ private void addPartition(boolean hasMorePartitions, AlterTableAddPartitionDesc
     );
 
     boolean isOnlyDDLOperation = event.replicationSpec().isMetadataOnly()
-            || event.replicationSpec().isMetadataOnlyForExternalTables()
+            || Utils.shouldDumpMetaDataOnlyForExternalTables(table, context.hiveConf)
 
 Review comment:
   No need of this check, its already true for external table ((TableType.EXTERNAL_TABLE.equals(table.getTableType())

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org


[GitHub] [hive] maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #945: HIVE-22998 Dump partition info if hive.repl.dump.metadata.only.for.ex…
URL: https://github.com/apache/hive/pull/945#discussion_r391378029
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AbstractEventHandler.java
 ##########
 @@ -94,7 +94,8 @@ protected void writeFileEntry(String dbName, Table table, String file, BufferedW
           throws IOException, LoginException, MetaException, HiveFatalException {
     HiveConf hiveConf = withinContext.hiveConf;
     String distCpDoAsUser = hiveConf.getVar(HiveConf.ConfVars.HIVE_DISTCP_DOAS_USER);
-    if (!Utils.shouldDumpMetaDataOnly(table, withinContext.hiveConf)) {
+    if (!Utils.shouldDumpMetaDataOnlyForExternalTables(table, withinContext.hiveConf)
 
 Review comment:
   for external table we don't dump data related events ..so i don't think we need to add this check 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org