You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/16 21:26:02 UTC

[jira] [Commented] (NIFI-4784) ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes

    [ https://issues.apache.org/jira/browse/NIFI-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327843#comment-16327843 ] 

ASF GitHub Bot commented on NIFI-4784:
--------------------------------------

GitHub user sbouchex opened a pull request:

    https://github.com/apache/nifi/pull/2407

    NIFI-4784 ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x ] Have you written or updated unit tests to verify your changes?
    - [ x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [x ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/infovista/nifi NIFI-4784

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2407.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2407
    
----
commit 7286994dccf4091b09eeb8de1bc43e373991e8ae
Author: sbouchex <sb...@...>
Date:   2018-01-16T21:23:51Z

    Fixed runStatus allowedValues

----


> ProcessorStatusSnapshotDTO and ProcessorStatusDTO annotation fixes
> ------------------------------------------------------------------
>
>                 Key: NIFI-4784
>                 URL: https://issues.apache.org/jira/browse/NIFI-4784
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.5.0
>         Environment: All
>            Reporter: Sébastien Bouchex Bellomié
>            Priority: Minor
>
> Following NIFI-4615  , it appears that the allowableValues annotation for the ProcessorStatusDTO and ProcessorStatusSnapshotDTO classes  are incorrect as the runStatus coming from org.apache.nifi.controller.status.RunStatus enum with the values "Running", "Stopped", "Invalid", "Disabled" are not uppercase.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)