[GitHub] [flink] masteryhx commented on a diff in pull request #19142: [FLINK-23252][changelog] Support recovery from checkpoint after disab…

[GitBox <gi...@apache.org>]

masteryhx commented on code in PR #19142:
URL: https://github.com/apache/flink/pull/19142#discussion_r847968836


##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java:
##########
@@ -391,7 +394,7 @@ static void serializeKeyedStateHandle(KeyedStateHandle stateHandle, DataOutputSt
             dos.writeLong(handle.getStateSize());
             dos.writeLong(handle.getCheckpointedSize());
             writeStateHandleId(handle, dos);
-
+            dos.writeUTF(handle.getStorageIdentifier());

Review Comment:
   I am thinking a more common case about switching the change log storage.
   There are some problems in current implementation which use same change log storage to read and write.
   I think we should use original change log storage to read and use new one to write.
   It also make sense for switching from enabled to disabled.
   But we cannot get original change log storage currently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org