You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/11/16 21:36:24 UTC
[GitHub] [geode-native] echobravopapa commented on a change in pull request #690: GEODE-8693: throw NotConnectedException if server goes down while exe…
echobravopapa commented on a change in pull request #690:
URL: https://github.com/apache/geode-native/pull/690#discussion_r524592099
##########
File path: cppcache/src/ThinClientPoolDM.cpp
##########
@@ -2414,7 +2415,7 @@ GfErrType FunctionExecution::execute() {
m_error = m_poolDM->sendRequestToEP(request, reply, m_ep);
m_error = m_poolDM->handleEPError(m_ep, reply, m_error);
if (m_error != GF_NOERR) {
- if (m_error == GF_NOTCON || m_error == GF_IOERR) {
+ if (m_error == GF_NOTCON) {
Review comment:
how did you determine we no longer need to check for`GF_IOERR`?
##########
File path: cppcache/src/ThinClientPoolDM.cpp
##########
@@ -670,11 +670,12 @@ GfErrType ThinClientPoolDM::sendRequestToAllServers(
err == GF_NOT_AUTHORIZED_EXCEPTION ||
err == GF_AUTHENTICATION_REQUIRED_EXCEPTION) {
finalErrorReturn = err;
- } else if (!(finalErrorReturn == GF_AUTHENTICATION_FAILED_EXCEPTION ||
- finalErrorReturn == GF_NOT_AUTHORIZED_EXCEPTION ||
- finalErrorReturn ==
- GF_AUTHENTICATION_REQUIRED_EXCEPTION)) // returning auth
- // errors
+ } else if ((err != GF_NOERR) &&
Review comment:
the check for `!GF_NOERR` looks like a good addition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org