You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/09/07 16:26:51 UTC

[GitHub] rob05c opened a new issue #2793: Make Traffic Ops "API Tests" use seeds.sql

rob05c opened a new issue #2793: Make Traffic Ops "API Tests" use seeds.sql
URL: https://github.com/apache/trafficcontrol/issues/2793
 
 
   Right now, The TO "API Tests" don't use seeds.sql, which has a number of issues:
   1. The sql commands required by the tests have to be copy-pasted into the tests. For example, for capabilities, this is 200+ lines of duplicate code.
   2. Changes to seeds.sql will break the tests, unless they're also copy-pasted in.
   3. Changes to seeds.sql which change behavior could break an endpoint, but the "API Tests" will still pass because they're copy-pasted.
   4. The seeds.sql is not being tested. Ideally, the TO tests should verify that the seeds.sql works correctly, as part of verifying TO works.
   
   The "API Test" framework should be changed to use seed.sql, rather than copying its contents, to fix these issues, and improve test coverage in general. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services