You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2017/03/22 11:58:54 UTC
Review Request 57837: Remember filters on all tabs of Ranger Audits
page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57837/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1471
https://issues.apache.org/jira/browse/RANGER-1471
Repository: ranger
Description
-------
Currently, when we apply filter for anything in Ranger Audit page for any of the tabs. It resets the filter on change of tab or if we move to any other page in Ranger.
Planning to add feature of remembering latest filters on all Tabs of Audits page. That will help users to stay focused on what they are looking for in audits tab and users will not have to apply for filters again and again to check audit events of a particular service.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 0723ee9
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java f0d2401
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 85f420d
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 1551d86
security-admin/src/main/webapp/scripts/utils/XAUtils.js 7a35ce3
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 8a0abb8
security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 6f1069d
security-admin/src/main/webapp/styles/xa.css 7a5ec2e
security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html ea2f198
security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 028fdbf
security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html ddd6e3d
security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java c544832
Diff: https://reviews.apache.org/r/57837/diff/1/
Testing
-------
1. Tested multiple search is working correctly in "Audit" tab.
2. Tested search remains the same when we navigate from one tab to other.
3. Tested search is working correctly for different user role.
Thanks,
bhavik patel
Re: Review Request 57837: Remember filters on all tabs of Ranger
Audits page
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57837/#review173197
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On April 26, 2017, 4:41 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57837/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 4:41 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1471
> https://issues.apache.org/jira/browse/RANGER-1471
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, when we apply filter for anything in Ranger Audit page for any of the tabs. It resets the filter on change of tab or if we move to any other page in Ranger.
> Planning to add feature of remembering latest filters on all Tabs of Audits page. That will help users to stay focused on what they are looking for in audits tab and users will not have to apply for filters again and again to check audit events of a particular service.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java fe253ef
> security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java ed34525
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021
> security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 0a30cf6
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4a153bf
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 480c515
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 1277334
> security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 6f1069d
> security-admin/src/main/webapp/styles/xa.css 7a5ec2e
> security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html ea2f198
> security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 028fdbf
> security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html ddd6e3d
> security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java c544832
>
>
> Diff: https://reviews.apache.org/r/57837/diff/4/
>
>
> Testing
> -------
>
> 1. Tested multiple search is working correctly in "Audit" tab.
> 2. Tested search remains the same when we navigate from one tab to other.
> 3. Tested search is working correctly for different user role.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 57837: Remember filters on all tabs of Ranger
Audits page
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57837/#review173218
-----------------------------------------------------------
Ship it!
Ship It!
- Gautam Borad
On April 26, 2017, 4:41 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57837/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 4:41 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1471
> https://issues.apache.org/jira/browse/RANGER-1471
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, when we apply filter for anything in Ranger Audit page for any of the tabs. It resets the filter on change of tab or if we move to any other page in Ranger.
> Planning to add feature of remembering latest filters on all Tabs of Audits page. That will help users to stay focused on what they are looking for in audits tab and users will not have to apply for filters again and again to check audit events of a particular service.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java fe253ef
> security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java ed34525
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021
> security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 0a30cf6
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4a153bf
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 480c515
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 1277334
> security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 6f1069d
> security-admin/src/main/webapp/styles/xa.css 7a5ec2e
> security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html ea2f198
> security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 028fdbf
> security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html ddd6e3d
> security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java c544832
>
>
> Diff: https://reviews.apache.org/r/57837/diff/4/
>
>
> Testing
> -------
>
> 1. Tested multiple search is working correctly in "Audit" tab.
> 2. Tested search remains the same when we navigate from one tab to other.
> 3. Tested search is working correctly for different user role.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 57837: Remember filters on all tabs of Ranger
Audits page
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57837/
-----------------------------------------------------------
(Updated April 26, 2017, 4:41 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1471
https://issues.apache.org/jira/browse/RANGER-1471
Repository: ranger
Description
-------
Currently, when we apply filter for anything in Ranger Audit page for any of the tabs. It resets the filter on change of tab or if we move to any other page in Ranger.
Planning to add feature of remembering latest filters on all Tabs of Audits page. That will help users to stay focused on what they are looking for in audits tab and users will not have to apply for filters again and again to check audit events of a particular service.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java fe253ef
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java ed34525
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 0a30cf6
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4a153bf
security-admin/src/main/webapp/scripts/utils/XAUtils.js 480c515
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 1277334
security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 6f1069d
security-admin/src/main/webapp/styles/xa.css 7a5ec2e
security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html ea2f198
security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 028fdbf
security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html ddd6e3d
security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java c544832
Diff: https://reviews.apache.org/r/57837/diff/4/
Changes: https://reviews.apache.org/r/57837/diff/3-4/
Testing
-------
1. Tested multiple search is working correctly in "Audit" tab.
2. Tested search remains the same when we navigate from one tab to other.
3. Tested search is working correctly for different user role.
Thanks,
bhavik patel
Re: Review Request 57837: Remember filters on all tabs of Ranger
Audits page
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57837/
-----------------------------------------------------------
(Updated April 19, 2017, 6:45 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1471
https://issues.apache.org/jira/browse/RANGER-1471
Repository: ranger
Description
-------
Currently, when we apply filter for anything in Ranger Audit page for any of the tabs. It resets the filter on change of tab or if we move to any other page in Ranger.
Planning to add feature of remembering latest filters on all Tabs of Audits page. That will help users to stay focused on what they are looking for in audits tab and users will not have to apply for filters again and again to check audit events of a particular service.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java fe253ef
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java f0d2401
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 049985c
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8f7d5d9
security-admin/src/main/webapp/scripts/utils/XAUtils.js 480c515
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 8a0abb8
security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 6f1069d
security-admin/src/main/webapp/styles/xa.css 7a5ec2e
security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html ea2f198
security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 028fdbf
security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html ddd6e3d
security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java c544832
Diff: https://reviews.apache.org/r/57837/diff/3/
Changes: https://reviews.apache.org/r/57837/diff/2-3/
Testing
-------
1. Tested multiple search is working correctly in "Audit" tab.
2. Tested search remains the same when we navigate from one tab to other.
3. Tested search is working correctly for different user role.
Thanks,
bhavik patel
Re: Review Request 57837: Remember filters on all tabs of Ranger
Audits page
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57837/
-----------------------------------------------------------
(Updated April 3, 2017, 8:55 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1471
https://issues.apache.org/jira/browse/RANGER-1471
Repository: ranger
Description
-------
Currently, when we apply filter for anything in Ranger Audit page for any of the tabs. It resets the filter on change of tab or if we move to any other page in Ranger.
Planning to add feature of remembering latest filters on all Tabs of Audits page. That will help users to stay focused on what they are looking for in audits tab and users will not have to apply for filters again and again to check audit events of a particular service.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java 0723ee9
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java f0d2401
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 0776021
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 85f420d
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8f7d5d9
security-admin/src/main/webapp/scripts/utils/XAUtils.js 7a35ce3
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 8a0abb8
security-admin/src/main/webapp/scripts/views/reports/LoginSessionDetail.js 6f1069d
security-admin/src/main/webapp/styles/xa.css 7a5ec2e
security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html ea2f198
security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html 028fdbf
security-admin/src/main/webapp/templates/reports/LoginSessionDetail_tmpl.html ddd6e3d
security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java c544832
Diff: https://reviews.apache.org/r/57837/diff/2/
Changes: https://reviews.apache.org/r/57837/diff/1-2/
Testing
-------
1. Tested multiple search is working correctly in "Audit" tab.
2. Tested search remains the same when we navigate from one tab to other.
3. Tested search is working correctly for different user role.
Thanks,
bhavik patel