You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/31 17:50:09 UTC

[GitHub] [spark] dhirennavani commented on a change in pull request #34450: [SPARK-37171][SQL]Add forany and forall to Datasets/Dataframes

dhirennavani commented on a change in pull request #34450:
URL: https://github.com/apache/spark/pull/34450#discussion_r739855090



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1638,6 +1638,58 @@ class Dataset[T] private[sql](
       c5: TypedColumn[T, U5]): Dataset[(U1, U2, U3, U4, U5)] =
     selectUntyped(c1, c2, c3, c4, c5).asInstanceOf[Dataset[(U1, U2, U3, U4, U5)]]
 
+  /**
+   * Checks if the condition is true for any of the rows.
+   * {{{
+   *   peopleDs.forany($"age" > 15)
+   * }}}
+   *
+   * @group typedrel
+   * @since 3.2.0

Review comment:
       That’s true. So do you recommend we drop this as it would be too much to implement in R and Python?
   
   I believe the code is for Scala API. 
   Just FYI, isEmpty method is absent in Python API although present in Scala API. 
   
   Let me know if we still wanna go forward, I can change the version then. If you let me know the right version. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org