You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/11/03 00:15:10 UTC
[GitHub] [openwhisk-runtime-python] meenakshimadugula95 opened a new pull request, #135: Script to build docker images locally
meenakshimadugula95 opened a new pull request, #135:
URL: https://github.com/apache/openwhisk-runtime-python/pull/135
I was following the instructions to build the docker file locally by following the tutorial on [here](https://github.com/apache/openwhisk-runtime-python/blob/master/tutorials/local_build.md).
However the command for `docker build` was failing. I noticed failures in building the docker files for all available runtimes. The reason being the expected dependent files/folders were not available in the docker context. The Gradle builds would essentially pass as they are copying the dependencies before building the docker. For example https://github.com/apache/openwhisk-runtime-python/blob/master/core/python3Action/build.gradle#L25
To solve this problem, I had brainstormed multiple solutions, I came up with this one as it does not affect any dependencies on the dockerfile. The gradle builds should be able to pass as they were earlier.
Solution:
- Create a script that would take in two arguments
1. Runtime folder name - The runtime that needs to be built
2. Docker Image tag - Name of the docker image
- Example command `./tutorials/local_build.sh -r python3Action -t action-python-v3.7:1.0-SNAPSHOT`
The script tries to mimic the Gradle files by copying the dependent folder/files, building the docker file and then deleting the dependent folders/files. I have updated the tutorial document with the same instructions. This PR would help anyone trying to build the runtime images locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] mrutkows commented on pull request #135: Script to build docker images locally
Posted by GitBox <gi...@apache.org>.
mrutkows commented on PR #135:
URL: https://github.com/apache/openwhisk-runtime-python/pull/135#issuecomment-1314479463
@meenakshimadugula95 Apart from specific review comments... Could we also, in this PR, update the top-level README to better inform people what they will find when referencing the "Docker" build path and also perhaps simplify (correct) the "two ways to build" section which is confusing IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] mrutkows commented on a diff in pull request #135: Script to build docker images locally
Posted by GitBox <gi...@apache.org>.
mrutkows commented on code in PR #135:
URL: https://github.com/apache/openwhisk-runtime-python/pull/135#discussion_r1022125651
##########
tutorials/local_build.md:
##########
@@ -33,9 +33,12 @@ cd openwhisk-runtime-python
2. Build docker
Build using Python 3.7 (recommended). This tutorial assumes you're building with python 3.7.
-
+Run local_build.sh with the correct parameters to build docker
Review Comment:
Hoping that you could help out and make this markdown more readable?
- Reduce the use of numbered lists (and do not start at zero 0.)
- Create more subsection headings to break up the numbered lists
- e.g., "Build the iamge", "Run the image", "Test the image" (with Curl) etc.
- Create subsections that show case "Testing with Helloworld" and explain init/run entry points into image.
May wish to align with work in the nodejs runtime's README and docker build/run/test README:
https://github.com/apache/openwhisk-runtime-nodejs/pull/227
Please know further updates to the files there are expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] meenakshimadugula95 commented on pull request #135: Script to build docker images locally
Posted by GitBox <gi...@apache.org>.
meenakshimadugula95 commented on PR #135:
URL: https://github.com/apache/openwhisk-runtime-python/pull/135#issuecomment-1319404063
@mrutkows thank you for the comments. I have modified the tutorial file so that it is better structured and easily readable. Please review this while I edit the top level readme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] meenakshimadugula95 commented on pull request #135: Script to build docker images locally
Posted by GitBox <gi...@apache.org>.
meenakshimadugula95 commented on PR #135:
URL: https://github.com/apache/openwhisk-runtime-python/pull/135#issuecomment-1322851485
I have correct the top level readme to reflect the two option to build python runtimes. Please take a look and review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-python] mrutkows merged pull request #135: Script to build docker images locally
Posted by GitBox <gi...@apache.org>.
mrutkows merged PR #135:
URL: https://github.com/apache/openwhisk-runtime-python/pull/135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org