You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/08 05:46:37 UTC

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18254: [fix][broker] Deprecated aggregatePublisherStatsByProducerName config

michaeljmarshall commented on code in PR #18254:
URL: https://github.com/apache/pulsar/pull/18254#discussion_r1016166458


##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/PublisherStats.java:
##########
@@ -44,6 +44,7 @@ public interface PublisherStats {
     long getProducerId();
 
     /** Whether partial producer is supported at client. */
+    @Deprecated
     boolean isSupportsPartialProducer();

Review Comment:
   I think this is the correct change. If it has already been released, we cannot remove it without first deprecating it. I don't know that we have documented guidance on how long to keep methods like this marked as deprecated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org