[GitHub] [libcloud] Kami commented on a diff in pull request #1742: Add Filters to DO Images

[GitBox <gi...@apache.org>]

Kami commented on code in PR #1742:
URL: https://github.com/apache/libcloud/pull/1742#discussion_r961953324


##########
libcloud/compute/drivers/digitalocean.py:
##########
@@ -93,8 +94,21 @@ class DigitalOcean_v2_NodeDriver(DigitalOcean_v2_BaseDriver, DigitalOceanNodeDri
 
     EX_CREATE_ATTRIBUTES = ["backups", "ipv6", "private_networking", "tags", "ssh_keys"]
 
-    def list_images(self):
-        data = self._paginated_request("/v2/images", "images")
+    def list_images(self, ex_private: Optional[bool] = None, ex_tag_name: Optional[str] = None):
+        """
+        List all the available images.
+
+        :param ex_private: Filters only user (private) images.

Review Comment:
   Would be good to clarify that ``None`` (default value) means that no filtering is performed.
   
   Also, is there a distinction between ``None`` and ``False``? If there isn't, I think we should just default to ``False`` and remove ``Optional`` annotation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org