[GitHub] [ignite-3] sashapolo commented on a change in pull request #153: IGNITE-14715 Add annotation processor for generating network message implementations

[GitBox <gi...@apache.org>]

sashapolo commented on a change in pull request #153:
URL: https://github.com/apache/ignite-3/pull/153#discussion_r643155940



##########
File path: modules/network-annotation-processor/src/integrationTest/resources/org/apache/ignite/network/processor/internal/ConflictingTypeMessage.java
##########
@@ -17,11 +17,11 @@
 
 package org.apache.ignite.network.processor.internal;
 
-import java.util.Collection;
+import java.util.ArrayList;
 import org.apache.ignite.network.NetworkMessage;
-import org.apache.ignite.network.processor.annotations.AutoSerializable;
+import org.apache.ignite.network.annotations.AutoMessage;
 
-@AutoSerializable(messageFactory = AllTypesMessageFactory.class)
-public interface MissingBuilderMessage extends NetworkMessage {
+@AutoMessage(1)
+public interface ConflictingTypeMessage extends NetworkMessage {

Review comment:
       can you clarify please? I don't understand what you mean =(

##########
File path: modules/network-annotation-processor/src/integrationTest/resources/org/apache/ignite/network/processor/internal/AllTypesMessage.java
##########
@@ -23,12 +23,10 @@
 import java.util.UUID;
 import org.apache.ignite.lang.IgniteUuid;
 import org.apache.ignite.network.NetworkMessage;
-import org.apache.ignite.network.processor.annotations.AutoSerializable;
+import org.apache.ignite.network.annotations.AutoMessage;
 
-@AutoSerializable(messageFactory = AllTypesMessageFactory.class)
+@AutoMessage(1)

Review comment:
       can you clarify please? I don't understand what you mean =(




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org