You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2015/12/15 02:47:46 UTC
Re: Review Request 40062: MESOS-2315 Deprecate/Remove
CommandInfo::ContainerInfo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review110366
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Nov. 9, 2015, 9:16 p.m., Vaibhav Khanduja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 9:16 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-2315
> https://issues.apache.org/jira/browse/MESOS-2315
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b
> include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b
> src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4
> src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf
> src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598
>
> Diff: https://reviews.apache.org/r/40062/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Vaibhav Khanduja
>
>
Re: Review Request 40062: MESOS-2315 Deprecate/Remove
CommandInfo::ContainerInfo
Posted by Adam B <ad...@mesosphere.io>.
> On Dec. 14, 2015, 5:47 p.m., Adam B wrote:
> > Ship It!
Only missing piece is an API change mention in the CHANGELOG. I'll add that.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review110366
-----------------------------------------------------------
On Nov. 9, 2015, 9:16 p.m., Vaibhav Khanduja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 9:16 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-2315
> https://issues.apache.org/jira/browse/MESOS-2315
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b
> include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b
> src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4
> src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf
> src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598
>
> Diff: https://reviews.apache.org/r/40062/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Vaibhav Khanduja
>
>