You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "sabir-akhadov-localstack (via GitHub)" <gi...@apache.org> on 2026/09/01 08:57:05 UTC
[PR] Snowflake: Add SHOW EXTERNAL VOLUMES [datafusion-sqlparser-rs]
sabir-akhadov-localstack opened a new pull request, #2473:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2473
Snowflake's `SHOW EXTERNAL VOLUMES` did not parse:
```sql
SHOW EXTERNAL VOLUMES LIKE 'my_%';
```
This adds a `ShowExternalVolumes` statement to the Snowflake dialect, reusing the existing `ShowStatementFilter` for the optional `LIKE` clause. All statements round-trip.
See the [Snowflake `SHOW EXTERNAL VOLUMES` docs](https://docs.snowflake.com/en/sql-reference/sql/show-external-volumes).
Split out of #2397 per review feedback, alongside the CREATE/DROP (#2397), ALTER, and DESC PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Add SHOW EXTERNAL VOLUMES [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2473:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2473#issuecomment-6190559612
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2473?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `78.94737%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 81.16%. Comparing base ([`5d653a2`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/5d653a257a9dd981be1f2200c184b20547e75cf0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f9de697`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/f9de697929c93284d0113cf09ba7d79e8ef7c7ca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2473?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [src/ast/mod.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2473?src=pr&el=tree&filepath=src%2Fast%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL2FzdC9tb2QucnM=) | 81.81% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/ast/spans.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2473?src=pr&el=tree&filepath=src%2Fast%2Fspans.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL2FzdC9zcGFucy5ycw==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/dialect/snowflake.rs](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2473?src=pr&el=tree&filepath=src%2Fdialect%2Fsnowflake.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL2RpYWxlY3Qvc25vd2ZsYWtlLnJz) | 85.71% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2473 +/- ##
==========================================
- Coverage 81.16% 81.16% -0.01%
==========================================
Files 42 42
Lines 33769 33788 +19
Branches 33769 33788 +19
==========================================
+ Hits 27408 27423 +15
- Misses 2797 2798 +1
- Partials 3564 3567 +3
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2473?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Add SHOW EXTERNAL VOLUMES [datafusion-sqlparser-rs]
Posted by "sabir-akhadov-localstack (via GitHub)" <gi...@apache.org>.
sabir-akhadov-localstack commented on PR #2473:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2473#issuecomment-6189848132
Rebased on latest main. @iffyio @LucaCappelletti94 could you take a look when you have a moment? (One of the PRs split out of #2397.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Add SHOW EXTERNAL VOLUMES [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2473:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2473#issuecomment-6189890761
At this time we are rather overworked review wise, so I'll get to it when I'll get to it. I would appreciate if you could help out with reviewing other PRs, as it would accelerate our work and ultimately speed up the PR queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org