[jira] [Created] (PIG-5311) POReservoirSample fails for more than Integer.MAX_VALUE records

["Rohini Palaniswamy (JIRA)" <ji...@apache.org>]

Rohini Palaniswamy created PIG-5311:
---------------------------------------

             Summary: POReservoirSample fails for more than Integer.MAX_VALUE records
                 Key: PIG-5311
                 URL: https://issues.apache.org/jira/browse/PIG-5311
             Project: Pig
          Issue Type: Bug
            Reporter: Rohini Palaniswamy
            Assignee: Rohini Palaniswamy
             Fix For: 0.18.0


https://github.com/apache/pig/blob/branch-0.17/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POReservoirSample.java#L128

The rowProcessed is a int. When it exceeds the int range it wraps around and becomes a negative number throwing below exception. It needs to be changed to long.

{code}
Caused by: java.lang.IllegalArgumentException: bound must be positive
  at java.util.Random.nextInt(Random.java:388)
  at org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POReservoirSample.getNextTuple(POReservoirSample.java:128)
  at org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.processInput(PhysicalOperator.java:305)
  at org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POForEach.getNextTuple(POForEach.java:284)
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)