You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2019/04/01 12:04:28 UTC

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12892

to look at the new patch set (#2).

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................

Make Docker-based tests available on more hosting OS platforms

Tweak the test driver and the monitoring code to be compatible with
more OS versions:

1. Change the code collecting memory statistics to go directly to
   /proc/meminfo instead of parsing the output of 'free', which
   requires different arguments on different OS distributions.
   This makes test-with-docker.py depend on the MemAvailable field
   in /proc/meminfo, which should be present on kernels v3.14 and above.
   This also foregoes forking 'free' once per second.

2. Relax the check for a valid timezone specifier.
   On Ubuntu 14.04 /etc/localtime is a copy of a timezone file instead
   of being a symlink to a timezone file.
   Add an alternative check that accepts this option for timezone
   synchronization between the host and the Docker containers.

3. Centos 6 did not like the leading dash in the 'ps' command argument
   list. Change this to a universally accepted form by dropping
   the leading dash.
   Tested by running 'ps axho' manually on all OSs supported for
   Docker-based tests.

Change-Id: I6d326611772facc193d8e509a827515f10207808
---
M docker/entrypoint.sh
M docker/monitor.py
M docker/test-with-docker.py
3 files changed, 51 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/12892/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>