You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by SrikanteswaraRao Talluri <sr...@citrix.com> on 2013/05/08 11:15:53 UTC

Review Request: Fix test_global_settings.py which is checking for the wrong global setting

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11006/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Description
-------

1. test_global_settings.py is checking the wrong global setting while validating the updated config
2. Need to add tags - advanced, basic, devcloud etc., 


This addresses bug CLOUDSTACK-2382.


Diffs
-----

  test/integration/smoke/test_global_settings.py a7cdb3e 

Diff: https://reviews.apache.org/r/11006/diff/


Testing
-------

tested


Thanks,

SrikanteswaraRao Talluri


Re: Review Request: Fix test_global_settings.py which is checking for the wrong global setting

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11006/#review20533
-----------------------------------------------------------

Ship it!


Commit 237397df3cd27626ebffef1e274ac8404620dfa4

- Kishan Kavala


On May 8, 2013, 9:15 a.m., SrikanteswaraRao Talluri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11006/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 9:15 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> 1. test_global_settings.py is checking the wrong global setting while validating the updated config
> 2. Need to add tags - advanced, basic, devcloud etc., 
> 
> 
> This addresses bug CLOUDSTACK-2382.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_global_settings.py a7cdb3e 
> 
> Diff: https://reviews.apache.org/r/11006/diff/
> 
> 
> Testing
> -------
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>


Re: Review Request: Fix test_global_settings.py which is checking for the wrong global setting

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11006/#review20414
-----------------------------------------------------------

Ship it!


Ship It!

- Harikrishna Patnala


On May 8, 2013, 9:15 a.m., SrikanteswaraRao Talluri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11006/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 9:15 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> 1. test_global_settings.py is checking the wrong global setting while validating the updated config
> 2. Need to add tags - advanced, basic, devcloud etc., 
> 
> 
> This addresses bug CLOUDSTACK-2382.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_global_settings.py a7cdb3e 
> 
> Diff: https://reviews.apache.org/r/11006/diff/
> 
> 
> Testing
> -------
> 
> tested
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>