[GitHub] [rocketmq] wxisme opened a new pull request #1475: Fix bug for splitting batch message in example code

[GitBox <gi...@apache.org>]

wxisme opened a new pull request #1475: Fix bug for splitting batch message in example code
URL: https://github.com/apache/rocketmq/pull/1475
 
 
   **There are two bugs in the batch message example code:**
   
   1. The 4MiB size limit should be based on `1024` instead of `1000`.
   2. The size of the topic and message properties should be calculated the number of bytes instead of the number of characters.
   
   **In addition these bugs also exist in the following documents:**
   http://rocketmq.cloud/zh-cn/docs/example-batch.html
   https://rocketmq.apache.org/docs/batch-example/
   
   
   - [ ] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services