You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/15 14:29:47 UTC

[GitHub] [solr] bruno-roustant commented on a change in pull request #18: SOLR-15261: SortedDocValues no longer extends BinaryDocValues

bruno-roustant commented on a change in pull request #18:
URL: https://github.com/apache/solr/pull/18#discussion_r594385042



##########
File path: solr/core/src/java/org/apache/solr/uninverting/FieldCacheImpl.java
##########
@@ -1076,10 +1076,6 @@ public BinaryDocValues getTerms(LeafReader reader, String field) throws IOExcept
 
   public BinaryDocValues getTerms(LeafReader reader, String field, float acceptableOverheadRatio) throws IOException {
     BinaryDocValues valuesIn = reader.getBinaryDocValues(field);
-    if (valuesIn == null) {

Review comment:
       I'm removing this part. It seems to me the SortedDocValues are returned by getTermsIndex() so we don't need this block.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org