[GitHub] [cassandra] lmtrombone commented on a diff in pull request #1949: CASSANDRA-16491 track and handle errors during nodetool bootstrap resume properly

[GitBox <gi...@apache.org>]

lmtrombone commented on code in PR #1949:
URL: https://github.com/apache/cassandra/pull/1949#discussion_r1006468044


##########
src/java/org/apache/cassandra/tools/BootstrapMonitor.java:
##########
@@ -82,9 +83,19 @@ public void progress(String tag, ProgressEvent event)
             message = message + " (progress: " + (int)event.getProgressPercentage() + "%)";
         }
         out.println(message);
+        if (type == ProgressEventType.ERROR)
+        {
+            error = new RuntimeException(String.format("Bootstrap resume has failed with error: %s", message));
+            condition.signalAll();

Review Comment:
   @maedhroz Since I reverted my changes where I removed the `ProgressEventType.COMPLETE` event that was being sent, I assume we can just rely on the logic below (lines 91-94) where it already calls `condition.signalAll();`?   When we encounter an issue, I noticed that we always both `ProgressEventType.ERROR` and `ProgressEventType.COMPLETE` events so it seems a little redundant and unnecessary now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org