You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Frank Zhang <Fr...@citrix.com> on 2013/02/27 02:10:30 UTC

[DISCUSS] wrong maven configure for cloud-agent/cloud-server

I encounter failure of compile after deleting my .m2/ cache
The root cause is cloud-utils is set as 'test' scope in agent/pom.xml and server/pom.xml, but cloud-utils itself is not 'test' scope.
I suspect it's a wrong setting and made below patch. If nobody rises special reason I would apply this patch tomorrow.

diff --git a/agent/pom.xml b/agent/pom.xml
index 810f33f..0fc372d 100644
--- a/agent/pom.xml
+++ b/agent/pom.xml
@@ -35,8 +35,6 @@
       <groupId>org.apache.cloudstack</groupId>
       <artifactId>cloud-utils</artifactId>
       <version>${project.version}</version>
-      <classifier>tests</classifier>
-      <scope>test</scope>
     </dependency>
   </dependencies>
   <build>
diff --git a/server/pom.xml b/server/pom.xml
index 602ed5b..a3dab6f 100644
--- a/server/pom.xml
+++ b/server/pom.xml
@@ -77,8 +77,6 @@
       <groupId>org.apache.cloudstack</groupId>
       <artifactId>cloud-utils</artifactId>
       <version>${project.version}</version>
-      <classifier>tests</classifier>
-      <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>org.reflections</groupId>

Re: [DISCUSS] wrong maven configure for cloud-agent/cloud-server

Posted by Rohit Yadav <bh...@apache.org>.
On Wed, Feb 27, 2013 at 6:40 AM, Frank Zhang <Fr...@citrix.com> wrote:
> I encounter failure of compile after deleting my .m2/ cache
> The root cause is cloud-utils is set as 'test' scope in agent/pom.xml and server/pom.xml, but cloud-utils itself is not 'test' scope.
> I suspect it's a wrong setting and made below patch. If nobody rises special reason I would apply this patch tomorrow.

Frank, your patch looks fine.
But from git blame, I would still ask Darren Shepard and Hugo to
advise us if this is alright?

Regards.

>
> diff --git a/agent/pom.xml b/agent/pom.xml
> index 810f33f..0fc372d 100644
> --- a/agent/pom.xml
> +++ b/agent/pom.xml
> @@ -35,8 +35,6 @@
>        <groupId>org.apache.cloudstack</groupId>
>        <artifactId>cloud-utils</artifactId>
>        <version>${project.version}</version>
> -      <classifier>tests</classifier>
> -      <scope>test</scope>
>      </dependency>
>    </dependencies>
>    <build>
> diff --git a/server/pom.xml b/server/pom.xml
> index 602ed5b..a3dab6f 100644
> --- a/server/pom.xml
> +++ b/server/pom.xml
> @@ -77,8 +77,6 @@
>        <groupId>org.apache.cloudstack</groupId>
>        <artifactId>cloud-utils</artifactId>
>        <version>${project.version}</version>
> -      <classifier>tests</classifier>
> -      <scope>test</scope>
>      </dependency>
>      <dependency>
>        <groupId>org.reflections</groupId>