You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Paul Rogers (JIRA)" <ji...@apache.org> on 2017/08/19 19:58:02 UTC

[jira] [Commented] (DRILL-5730) Fix Unit Test failures on JDK 8 And Some JDK 7 versions

    [ https://issues.apache.org/jira/browse/DRILL-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134238#comment-16134238 ] 

Paul Rogers commented on DRILL-5730:
------------------------------------

Note that earlier work fixed the JDBC driver so it works with JDK 8.

Drill uses the JMockit mocking framework. When running in Eclipse, that framework only works in JDK 7. JMockit mucks with byte codes, and it will fail if asked to work with JDK 8 byte codes, at least in Eclipse. This is further complicated because the JMockit author is forever tinkering with the code and changing the public API. The current version is incompatible with the 2-3 year old version that Drill uses.

Possible solutions:

* Don't change the Java version. (Default solution that is becoming ever less tenable.)
* Upgrade, but require that people use IntelliJ to debug the JMockit unit tests. (Somehow, IntelliJ resolves the issues.)
* Rewrite the unit tests to use the latest JMockit.
* Rewrite the unit tets to use Mockito instead of JMockit.
* Rewrite the unit tests to use the "sub operator" test framework which does not require mocking.

The preferred solution preserves the ability to use Eclipse to work on Drill.

> Fix Unit Test failures on JDK 8 And Some JDK 7 versions
> -------------------------------------------------------
>
>                 Key: DRILL-5730
>                 URL: https://issues.apache.org/jira/browse/DRILL-5730
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>
> Tests fail on JDK 8 and oracle JDK 7 on my mac
> Failed tests: 
>   TestMetadataProvider.tables:153 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithTableNameFilter:212 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithSystemTableFilter:187 expected:<OK> but was:<FAILED>
>   TestMetadataProvider.tablesWithTableFilter:176 expected:<OK> but was:<FAILED>
> Tests in error: 
>   TestInfoSchema.selectFromAllTables » UserRemote SYSTEM ERROR: URISyntaxExcepti...
>   TestCustomUserAuthenticator.positiveUserAuth » UserRemote SYSTEM ERROR: URISyn...
>   TestCustomUserAuthenticator.positiveUserAuthAfterNegativeUserAuth » UserRemote
>   TestViewSupport.infoSchemaWithView:350->BaseTestQuery.testRunAndReturn:344 » Rpc
>   TestParquetScan.testSuccessFile:58->BaseTestQuery.testRunAndReturn:344 » Rpc o...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)