[GitHub] [netbeans] matthiasblaesing commented on pull request #5641: CSS: Support class/elements names with colons and fix HTML character entity completion

["matthiasblaesing (via GitHub)" <gi...@apache.org>]

matthiasblaesing commented on PR #5641:
URL: https://github.com/apache/netbeans/pull/5641#issuecomment-1464463836

   @junichi11 @KacerCZ  could you please have a look at this PR? I have a serious problem with one of the `php.editor` unittests.
   
   For a quick glance, you can have a look here: https://github.com/apache/netbeans/actions/runs/4386975881
   
   There are two problems I don't understand:
   
   1. The reformatted contents differs between the two platforms (compare actual reformatted result for Linux and Windows)
   2. Both unittest results do not match the result I get when running the build interactively:
   
   ![image](https://user-images.githubusercontent.com/2179736/224420619-cf580054-3b09-4264-a4e7-c095a263d3ef.png)
   
   The problem in the unittest can be reproduced locally by running:
   
   ```
   ant -f php/php.editor -Dtest.type=unit -Dtest.class=org.netbeans.modules.php.editor.js.JsFormatterEmbeddedTest -Dtest.methods=testEmbeddedMultipleSections1  test-method
   ```
   
   Running the test multiple times gives me sometimes the windows and sometimes the linux result. Something is fishy here, especially that this looks like a heisenbug.
   
   Changes in the indention are kind of expected. The formatting in the test relied on the CSS indenter having run. This was the case because the `id="source"` attribute in the `script` attribute was recognized as CSS. This behavior was modified, the id attribute is parsed and handled as a normal html attribute. You can observe differing idention when you test master and replace `id=` with `ic=`. The latter will not trigger the special casing.
   
   Any ideas are welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists