You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/06/08 10:26:47 UTC
[GitHub] [inlong] fuweng11 opened a new issue, #8192: [Bug][DataProxy] The topic name generated by dataproxy is incorrect
fuweng11 opened a new issue, #8192:
URL: https://github.com/apache/inlong/issues/8192
### What happened
The topic name generated by dataproxy is incorrect.
The following is the logic for creating kakfa topic on the manager side:
1.Get streamInfo.mqResource.
2.If streamInfo.mqResource equal to streamId, set topic to `groupInfo.mqResource.streamInfo.mqResource`
### What you expected to happen
The topic name generated by dataproxy is incorrect.
The following is the logic for creating kakfa topic on the manager side:
1.Get streamInfo.mqResource.
2.If streamInfo.mqResource equal to streamId, set topic to `groupInfo.mqResource.streamInfo.mqResource`
### How to reproduce
Set streamInfo.mqResource to rain streamId inconsistent.
### Environment
_No response_
### InLong version
master
### InLong Component
InLong DataProxy
### Are you willing to submit PR?
- [ ] Yes, I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on issue #8192: [Bug][DataProxy] The topic name generated by dataproxy is incorrect
Posted by "gosonzhang (via GitHub)" <gi...@apache.org>.
gosonzhang commented on issue #8192:
URL: https://github.com/apache/inlong/issues/8192#issuecomment-1582346013
@fuweng11, ok, got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on issue #8192: [Bug][DataProxy] The topic name generated by dataproxy is incorrect
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on issue #8192:
URL: https://github.com/apache/inlong/issues/8192#issuecomment-1582345304
> @fuweng11, I don't understand, the implementation[1] 
>
> is actually directly migrated [2]: 
>
> Is there a problem with the previous logic, then why is there no error reported?
>
> 1. https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/holder/MetaConfigHolder.java#L375
> 2. https://github.com/apache/inlong/blob/branch-1.7/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/kafka/KafkaHandler.java#L150
Yes, this problem was not discovered before because if `streamInfo.mqResource` is not set when the stream is created, the manager side will automatically set `streamId` to `streamInfo.mqResource`, and in most cases `streamId` and streamInfo.mqResource` are the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on issue #8192: [Bug][DataProxy] The topic name generated by dataproxy is incorrect
Posted by "gosonzhang (via GitHub)" <gi...@apache.org>.
gosonzhang commented on issue #8192:
URL: https://github.com/apache/inlong/issues/8192#issuecomment-1582339975
@fuweng11, I don't understand, the implementation[1]
is actually directly migrated [2]:
Is there a problem with the previous logic, then why is there no error reported?
1. https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/holder/MetaConfigHolder.java#L375
2. https://github.com/apache/inlong/blob/branch-1.7/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/mq/kafka/KafkaHandler.java#L150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang closed issue #8192: [Bug][DataProxy] The topic name generated by dataproxy is incorrect
Posted by "gosonzhang (via GitHub)" <gi...@apache.org>.
gosonzhang closed issue #8192: [Bug][DataProxy] The topic name generated by dataproxy is incorrect
URL: https://github.com/apache/inlong/issues/8192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org