You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2012/07/18 20:03:34 UTC
[jira] [Resolved] (LOGGING-128) Static analysis suggests a number
of potential improvements
[ https://issues.apache.org/jira/browse/LOGGING-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved LOGGING-128.
--------------------------
Resolution: Fixed
Fix Version/s: 1.1.2
Thanks, applied, apart from a few places where strings were being changed to characters. Also did not replace StringBuffer manipulation with String concatenation where not all input was fixed strings.
URL: http://svn.apache.org/viewvc?rev=1363030&view=rev
Log:
LOGGING-128 - Static analysis suggests a number of potential improvements
Modified:
commons/proper/logging/trunk/RELEASE-NOTES.txt
commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogSource.java
commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/Log4JLogger.java
commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/ServletContextCleaner.java
commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/WeakHashtable.java
> Static analysis suggests a number of potential improvements
> -----------------------------------------------------------
>
> Key: LOGGING-128
> URL: https://issues.apache.org/jira/browse/LOGGING-128
> Project: Commons Logging
> Issue Type: Improvement
> Reporter: Peter Lawrey
> Priority: Trivial
> Fix For: 1.1.2
>
> Attachments: commons-logging-static-analysis.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Improvements include;
> - final fields where possible
> - static methods where possible.
> - simplifying code to improve clarity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira