You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robpaveza <gi...@git.apache.org> on 2015/08/12 01:42:27 UTC
[GitHub] cordova-windows pull request: CB-9482: Modifies the deployment cod...
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/112
CB-9482: Modifies the deployment code to account for problems with
emulators, which are currently blocking the CI from executing. Modifying
the uninstall function to never fail appears to unblock the CI and allow
installation to emulators to continue unhindered.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-9482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit 6a5ff71c472d83275d4e4c8cdab4d99f2c3a2afa
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-08-11T23:40:29Z
CB-9482: Modifies the deployment code to account for problems with
emulators, which are currently blocking the CI from executing. Modifying
the uninstall function to never fail appears to unblock the CI and allow
installation to emulators to continue unhindered.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9482: Modifies the deployment cod...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/112#issuecomment-130335077
There isn't a way to get a "proper" fix. The tool doesn't have a mechanism to query for the presence of a device (AppDeployCmd /EnumerateDevices always lists "0. Device"), nor a way to query for the presence of a particular app. The only thing we CAN do is try to uninstall the app, to ensure that it always gets uninstalled if it's there, and then to actually install the app. (AppDeployCmd does have an "update" option, but it fails if the app isn't already installed).
The problem is with the SDK tool, and given that Windows Phone 8.1 is now a revision out of date, it's unlikely we'll get a fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9482: Modifies the deployment cod...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/112#issuecomment-130132659
This seems fine in the interim, but let's make a note to keep the issue open until we can get a proper fix. By "proper", I mean things like checking for existence of a device before we try to uninstall, making uninstall more reliable, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9482: Modifies the deployment cod...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/112#issuecomment-130133288
I rebased and forgot to add "This closes #112" to 050910c, sorry. You may close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9482: Modifies the deployment cod...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza closed the pull request at:
https://github.com/apache/cordova-windows/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org