[jira] [Commented] (SCB-387) Somefiles are lacking ASF header in Service Center

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394886#comment-16394886 ] 

ASF GitHub Bot commented on SCB-387:
------------------------------------

asifdxtreme opened a new pull request #303: SCB-387 Add ASF headers for auto-generated files
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/303
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Somefiles are lacking ASF header in Service Center
> --------------------------------------------------
>
>                 Key: SCB-387
>                 URL: https://issues.apache.org/jira/browse/SCB-387
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Service-Center
>            Reporter: Yang Bo
>            Assignee: Mohammad Asif Siddiqui
>            Priority: Major
>             Fix For: service-center-1.0.0-m1
>
>
> The following files does not have ASF headers
> src:
>   ./server/broker/broker.pb.go
>   ./server/broker/broker.proto
>   ./server/core/proto/services.pb.go
>   ./server/core/proto/services.proto 
>   ./server/core/swagger/v3.yaml
>   ./server/core/swagger/v4.yaml
> The pb.go files are generated by protobuf utility, perhaps we can exclude it for checking. But the .proto files should have the ASF header.
> bin:
>   ./conf/app.conf
> The apache policy states that only files that have no creativity and some simple template files for code generation can have the header omitted. Other files should all have the header included.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)