You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by deathbearbrown <gi...@git.apache.org> on 2014/07/23 20:45:54 UTC
[GitHub] couchdb-fauxton pull request: Changed how these files are named so...
GitHub user deathbearbrown opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/16
Changed how these files are named so it's easier to read in the addon
I am working in another branch on for the index refactor and as I was breaking things out more coherently there I realized that I would rather we use the convention type-thing.js to name files
That way if we have multiple route object files we could do:
routes-filters.js
views-filters.js
and it'll be easier to find which type of files we are looking for.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/deathbearbrown/couchdb-fauxton changed-my-mind
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit 893e9881d789f3b8c621bd6148130e1327cde638
Author: deathbearbrown <de...@gmail.com>
Date: 2014-07-23T18:41:23Z
Changed how these files are named so it's easier to read in the addon folders
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Changed how these files are named so...
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/16#issuecomment-49918363
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Changed how these files are named so...
Posted by jennschiffer <gi...@git.apache.org>.
Github user jennschiffer commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/16#issuecomment-49918370
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Changed how these files are named so...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Changed how these files are named so...
Posted by ocelotpotpie <gi...@git.apache.org>.
Github user ocelotpotpie commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/16#issuecomment-49918002
This gets a +1 from me, for whatever that's worth.
Putings `views-` first is a lot more legible at a glance
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Changed how these files are named so...
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/16#issuecomment-49918487
:cake: :heart: :womans_hat:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Changed how these files are named so...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/16#issuecomment-49926539
looks good to me. Otherwise just create a views folder then you don't need to append the views part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Changed how these files are named so...
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/16#issuecomment-49918409
you guys are great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---