You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/06 08:11:16 UTC
[PR] Add Java collection declaration rules [shardingsphere]
terrymanu opened a new pull request, #39747:
URL: https://github.com/apache/shardingsphere/pull/39747
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Java collection declaration rules [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39747:
URL: https://github.com/apache/shardingsphere/pull/39747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Java collection declaration rules [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39747:
URL: https://github.com/apache/shardingsphere/pull/39747#issuecomment-5557948821
### Result
**Review Result: Mergeable**
The collection declaration standard is correctly implemented for code generation and standalone compliance audits, with one authoritative rule source and no duplicate policy.
### Evidence
- `.codex/skills/coding-standards/references/rules/java-collections.md:18` defines the semantic rules and justified exceptions for `Collection`, `List`, `Set`, `Queue`, and concrete implementations.
- `.codex/skills/coding-standards/SKILL.md:42` activates the rules during implementation and review; line 80 activates them during standalone audits.
- `.codex/skills/code-implementation/references/rules/implementation.md:42` preserves the existing design entrypoint through a direct reference without duplicating the rules.
- `.codex/harness/agents/policy-sources.toml:21` registers the source for write, design, review, audit, unit-test-generation, and PR-review profiles.
- `.codex/harness/agents/cases.toml:1237` adds implementation and standalone-audit semantic coverage.
- Policy validation and local bootstrap validation passed.
- New semantic cases: 2/2 passed.
- Final full evaluation: 134/134 semantic cases and 246/246 source-read traces passed, with zero critical regressions.
- Skill validation and `git diff --check` passed.
- Checkstyle and Spotless are not applicable to these `.codex` Markdown and TOML files.
### Coverage
Standalone local candidate reviewed from baseline `ccd810b5fde420481c094d5a5f85debc5c9740ec`. All five task files and the rule semantics, activation paths, capability migration, source manifest, semantic tests, false-positive boundaries, and regression evidence were reviewed. The three pre-existing untracked `__pycache__` directories were excluded and left unchanged. All review lenses and the convergence pass completed with no unresolved gaps. This is a code-scope result; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org