You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/06 06:37:48 UTC

[GitHub] [beam] reubenvanammers commented on pull request #14974: [BEAM-12464] Change ProtoSchemaTranslator beam schema creation to match the order for protobufs containing Oneof fields

reubenvanammers commented on pull request #14974:
URL: https://github.com/apache/beam/pull/14974#issuecomment-874500254


   > Folks, what do we what do next? Does this require additional discussions?
   
   I still believe this change to be worthwhile, considering that currently not all beam schemas containing unions can be converted to protobuf. What would be useful to know whether or not anyone foresees issues arising from this change of behaviour/ anything needs to be added or changed. It'd be useful to get some feedback.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org