Re: [PR] perf: Improve string expression microbenchmarks [datafusion-comet]

["mbutrovich (via GitHub)" <gi...@apache.org>]

mbutrovich commented on code in PR #3012:
URL: https://github.com/apache/datafusion-comet/pull/3012#discussion_r2665298822


##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometStringExpressionBenchmark.scala:
##########
@@ -35,43 +35,48 @@ case class StringExprConfig(
     query: String,
     extraCometConfigs: Map[String, String] = Map.empty)
 
-// spotless:off
 /**
  * Benchmark to measure performance of Comet string expressions. To run this benchmark:
- * `SPARK_GENERATE_BENCHMARK_FILES=1 make benchmark-org.apache.spark.sql.benchmark.CometStringExpressionBenchmark`
+ * {{{
+ *   SPARK_GENERATE_BENCHMARK_FILES=1 make benchmark-org.apache.spark.sql.benchmark.CometStringExpressionBenchmark
+ * }}}
  * Results will be written to "spark/benchmarks/CometStringExpressionBenchmark-**results.txt".
  */
-// spotless:on
 object CometStringExpressionBenchmark extends CometBenchmarkBase {
 
   // Configuration for all string expression benchmarks
   private val stringExpressions = List(
-    StringExprConfig("Substring", "select substring(c1, 1, 100) from parquetV1Table"),
     StringExprConfig("ascii", "select ascii(c1) from parquetV1Table"),
-    StringExprConfig("bitLength", "select bit_length(c1) from parquetV1Table"),
-    StringExprConfig("octet_length", "select octet_length(c1) from parquetV1Table"),
-    StringExprConfig("upper", "select upper(c1) from parquetV1Table"),
-    StringExprConfig("lower", "select lower(c1) from parquetV1Table"),
-    StringExprConfig("chr", "select chr(c1) from parquetV1Table"),
-    StringExprConfig("initCap", "select initCap(c1) from parquetV1Table"),
-    StringExprConfig("trim", "select trim(c1) from parquetV1Table"),
+    StringExprConfig("bit_length", "select bit_length(c1) from parquetV1Table"),
     StringExprConfig("btrim", "select btrim(c1) from parquetV1Table"),
-    StringExprConfig("ltrim", "select ltrim(c1) from parquetV1Table"),
-    StringExprConfig("rtrim", "select rtrim(c1) from parquetV1Table"),
-    StringExprConfig("lpad", "select lpad(c1, 120, 'x') from parquetV1Table"),
-    StringExprConfig("rpad", "select rpad(c1, 120, 'x') from parquetV1Table"),
+    StringExprConfig("chr", "select chr(c1) from parquetV1Table"),
     StringExprConfig("concat", "select concat(c1, c1) from parquetV1Table"),
-    StringExprConfig("concatws", "select concat_ws(' ', c1, c1) from parquetV1Table"),

Review Comment:
   That seems like a good catch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org