[GitHub] [airflow] ashb commented on a change in pull request #9247: CI: Propogate Exit Code Correctly

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #9247:
URL: https://github.com/apache/airflow/pull/9247#discussion_r439389659



##########
File path: scripts/ci/ci_run_airflow_testing.sh
##########
@@ -127,16 +127,4 @@ do
     fi
     exit ${EXIT_CODE}
 done
-
-# shellcheck disable=SC2016
-docker-compose --log-level INFO \
-  -f "${MY_DIR}/docker-compose/base.yml" \
-  -f "${MY_DIR}/docker-compose/backend-${BACKEND}.yml" \
-  "${INTEGRATIONS[@]}" \
-  "${DOCKER_COMPOSE_LOCAL[@]}" \
-     run airflow \
-       '/opt/airflow/scripts/ci/in_container/entrypoint_ci.sh "${@}"' \
-       /opt/airflow/scripts/ci/in_container/entrypoint_ci.sh "${@}"
-     # Note the command is there twice (!) because it is passed via bash -c
-     # and bash -c starts passing parameters from $0. TODO: fixme

Review comment:
       This seems needless, I agree, but this should have failed anyway, as wer are in `set -e` -- so any commandfailure should terminate the script.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org